Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete follows and subscriptions when deleting a space #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 5, 2024

When deleting a space, we should also delete all the related follows and subscriptions

@wa0x6e wa0x6e requested a review from ChaituVR July 5, 2024 05:33
@ChaituVR
Copy link
Member

ChaituVR commented Jul 5, 2024

Why delete follows and subscriptions 🤔 we should never delete anything ideally.

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 5, 2024

This is edge case, but if I follow a space, and it gets deleted, it will stay in my follows, and count toward my 25 spaces quota

@ChaituVR
Copy link
Member

ChaituVR commented Jul 5, 2024

True that, agree. but lets ask @bonustrack if he agree

@ChaituVR ChaituVR requested a review from bonustrack July 5, 2024 06:42
@ChaituVR
Copy link
Member

ChaituVR commented Jul 5, 2024

or maybe we can ignore deleted spaces while checking for limit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants