feat: store proposal, vote and follower count on space #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
requested review from
wa0x6e and
ChaituVR
and removed request for
wa0x6e
|
Need to update the schema.sql on the hub with the new columns, and reflect it to |
wa0x6e
reviewed
Feb 24, 2024
ChaituVR
requested changes
Feb 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
…abs/snapshot-sequencer into fabien/space-counters
wa0x6e
approved these changes
May 26, 2024
ChaituVR
requested changes
May 29, 2024
|
@ChaituVR What's blocking here ? |
ChaituVR
reviewed
Jul 8, 2024
Comment on lines
+23
to
+29
| await db.queryAsync( | ||
| 'UPDATE spaces SET proposal_count = (SELECT count(id) from proposals WHERE space = spaces.id)' | ||
| ); | ||
|
|
||
| await db.queryAsync( | ||
| 'UPDATE spaces SET follower_count = (SELECT count(id) from follows WHERE space = spaces.id)' | ||
| ); |
There was a problem hiding this comment.
Not sure if these work correctly 🤔 @wa0x6e you tried?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created 3 new columns on the "spaces" table,
proposal_count,vote_countandfollower_count, this get automatically updated if some action happening on the space, this will allows us later to remove some heavy queries that we have currently on the hub.