Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for starknet address #880

Merged
merged 16 commits into from
Jul 15, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 4, 2024

Fixes https://github.com/snapshot-labs/pitches/issues/83

This PR introduces some changes in order to accept starknet address as input (in where and id fields)

Changes

  • feat: add starknetAddress to where fields accepted values
  • feat: allow passing an array to where values, so we can format using evmAddress, or ['evmAddress', 'starknetAddress']
  • refactor: rename EVMAddress to evmAddress in where fields formatter
  • refactor: remove @ethersproject/address as dependency, will use the formatter exported by snapshot.js

How to tests

src/graphql/helpers.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested review from ChaituVR and removed request for ChaituVR July 4, 2024 11:58
@wa0x6e wa0x6e marked this pull request as draft July 4, 2024 11:58
@wa0x6e wa0x6e marked this pull request as ready for review July 4, 2024 12:23
@wa0x6e wa0x6e requested a review from ChaituVR July 4, 2024 12:29
src/graphql/helpers.ts Outdated Show resolved Hide resolved
src/graphql/operations/user.ts Outdated Show resolved Hide resolved
src/graphql/helpers.ts Outdated Show resolved Hide resolved
src/graphql/helpers.ts Outdated Show resolved Hide resolved
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

added few comments but not too important

@wa0x6e wa0x6e requested a review from ChaituVR July 15, 2024 08:59
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 93da3f6 into master Jul 15, 2024
2 checks passed
@ChaituVR ChaituVR deleted the feat-add-starknet-address-support branch July 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants