-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for starknet address #880
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
added few comments but not too important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Fixes https://github.com/snapshot-labs/pitches/issues/83
This PR introduces some changes in order to accept starknet address as input (in
where
andid
fields)Changes
starknetAddress
towhere
fields accepted valueswhere
values, so we can format usingevmAddress
, or['evmAddress', 'starknetAddress']
EVMAddress
toevmAddress
inwhere
fields formatter@ethersproject/address
as dependency, will use the formatter exported by snapshot.jsHow to tests
yarn link
this branch of the SDK feat: support starknet signature verification snapshot.js#1032yarn dev