Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate AWS cache to use v3 api #208

Open
wants to merge 3 commits into
base: add-aws-tests
Choose a base branch
from
Open

fix: migrate AWS cache to use v3 api #208

wants to merge 3 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 31, 2024

Fix #177

Fix AWS SDK warnings

(node:29800) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy

Warnings does not go away completely after this fix, as some dependencies still are not updated

  • Migrate AWS cache to v3 api
  • Migrate providers to v3 api

TODO

@wa0x6e wa0x6e marked this pull request as draft January 31, 2024 10:56
@wa0x6e wa0x6e marked this pull request as ready for review January 31, 2024 11:13
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/aws.ts 80.32% 12 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@wa0x6e wa0x6e requested a review from ChaituVR January 31, 2024 11:21
@ChaituVR
Copy link
Member

How to test this

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jan 31, 2024

Tests

To test AWS cache:

  • Set your AWS credentials in .env
  • Pin a JSON file as usual, it should return the CID
  • Go to /ipfs/CID
  • It should return the pinned file
  • Go to your AWS account, it should have created a new file, with the correct content

To test 4everland:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants