Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
Tests for proposalFactory were failing, due to dependencies to redis. The tested function by themselves does not depend on redis, and thus are failing for unrelated reasons (connection to redis from bull)
💊 Fixes / Solution
Extract the tested function in another utils.ts file
🚧 Changes
newProposalDelay()
into its own helper file, isolating it from any side effects from the queue systemdist
folder from test path🛠️ Tests
yarn test
Failing tests for queue system are due to the way Bull is connecting to redis on CI. Will be
fixed by #67