Skip to content

Commit

Permalink
Pull Request Guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
silviomoreto committed Sep 4, 2013
1 parent 72a0f81 commit 9d577da
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,13 @@ Feature requests are welcome. But take a moment to find out whether your idea
fits with the scope and aims of the project. It's up to *you* to make a strong
case to convince the project's developers of the merits of this feature. Please
provide as much detail and context as possible.

## Pull Request Guidelines

* Please **do not** use `var _this = this`. Use `$.proxy` instead to keep the context.
* Submit your CLA, if you haven't.
* Please check to make sure that there aren't existing pull requests attempting to address the issue mentioned. We also recommend checking for issues related to the issue on the tracker, as a team member may be working on the issue in a branch or fork.
* Non-trivial changes should be discussed in an issue first
* If possible, use JSlint or JSHint to validate it
* If possible, add relevant tests to cover the change
* Write a convincing description of your PR and why we should land it

0 comments on commit 9d577da

Please sign in to comment.