Removed ICU dependency, as it increased APK sizes by 10MB

Author: ajungg

build.gradle

@@ -24,7 +24,7 @@ allprojects {
     }
 
     project.ext {
-        sdkVersion='0.6.15'
+        sdkVersion='0.6.16'
         versionCode=1
 
         compileSdkVersion=27

core/build.gradle

@@ -42,8 +42,6 @@ dependencies {
     implementation "com.squareup.okhttp3:logging-interceptor:${project.okhttpVersion}"
     implementation 'com.google.code.gson:gson:2.8.2'
 
-    api 'com.ibm.icu:icu4j:61.1'
-
     testImplementation 'junit:junit:4.12'
 
     androidTestImplementation 'com.android.support.test:rules:1.0.1'

core/src/main/java/io/snabble/sdk/SnabbleSdk.java

@@ -4,11 +4,10 @@
 import android.app.Application;
 import android.os.Bundle;
 
-import com.ibm.icu.util.Currency;
-
 import java.io.File;
 import java.math.RoundingMode;
 import java.util.Arrays;
+import java.util.Currency;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;

ui/src/main/java/io/snabble/sdk/ui/PriceFormatter.java

@@ -1,10 +1,8 @@
 package io.snabble.sdk.ui;
 
-
-import com.ibm.icu.text.NumberFormat;
-import com.ibm.icu.util.Currency;
-
 import java.math.BigDecimal;
+import java.text.NumberFormat;
+import java.util.Currency;
 
 import io.snabble.sdk.Product;
 import io.snabble.sdk.SnabbleSdk;
@@ -29,7 +27,18 @@ public String format(int price) {
         BigDecimal divider = new BigDecimal(10).pow(fractionDigits);
         BigDecimal dividedPrice = bigDecimal.divide(divider, fractionDigits, sdkInstance.getRoundingMode());
 
-        return numberFormat.format(dividedPrice.doubleValue());
+        String formattedPrice = numberFormat.format(dividedPrice.doubleValue());
+
+        // Android 4.x and 6 (but not 5 and 7+) are shipping with ICU versions
+        // that have the currency symbol set to HUF instead of Ft for Locale hu_HU
+        //
+        // including the whole ICU library as a dependency increased APK size by 10MB
+        // so we are overriding the result here instead for consistency
+        if(currency.getCurrencyCode().equals("HUF")){
+            return formattedPrice.replace("HUF", "Ft");
+        }
+
+        return formattedPrice;
     }
 
     public String format(Product product) {