Skip to content

Commit 7c73cb2

Browse files
committed
Fixed various price formatting issues by directly using com.ibm.icu
instead of relying on the operating systems shipped version
1 parent 14f396e commit 7c73cb2

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ allprojects {
2424
}
2525

2626
project.ext {
27-
sdkVersion='0.6.14'
27+
sdkVersion='0.6.15'
2828
versionCode=1
2929

3030
compileSdkVersion=27

core/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ dependencies {
4242
implementation "com.squareup.okhttp3:logging-interceptor:${project.okhttpVersion}"
4343
implementation 'com.google.code.gson:gson:2.8.2'
4444

45+
api 'com.ibm.icu:icu4j:61.1'
46+
4547
testImplementation 'junit:junit:4.12'
4648

4749
androidTestImplementation 'com.android.support.test:rules:1.0.1'

core/src/main/java/io/snabble/sdk/SnabbleSdk.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44
import android.app.Application;
55
import android.os.Bundle;
66

7+
import com.ibm.icu.util.Currency;
8+
79
import java.io.File;
810
import java.math.RoundingMode;
911
import java.util.Arrays;
10-
import java.util.Currency;
1112
import java.util.List;
1213
import java.util.Locale;
1314
import java.util.Map;

ui/src/main/java/io/snabble/sdk/ui/PriceFormatter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package io.snabble.sdk.ui;
22

3+
4+
import com.ibm.icu.text.NumberFormat;
5+
import com.ibm.icu.util.Currency;
6+
37
import java.math.BigDecimal;
4-
import java.math.RoundingMode;
5-
import java.text.NumberFormat;
6-
import java.util.Currency;
78

89
import io.snabble.sdk.Product;
910
import io.snabble.sdk.SnabbleSdk;

0 commit comments

Comments
 (0)