Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove createPort methods #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove createPort methods #284

wants to merge 1 commit into from

Conversation

hemberger
Copy link
Member

SmrPort::createPort is equivalent to getPort, so just
remove it. We can also remove the wrapper with the same name
from SmrSector.

@hemberger
Remove createPort methods
48af948 
`SmrPort::createPort` is equivalent to `getPort`, so just
remove it. We can also remove the wrapper with the same name
from `SmrSector`.
@hemberger hemberger requested a review from Page- January 16, 2018 10:07
Page-
Page- approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@Page- Page- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's a redundant method, although it is a shame to lose the hint that we're intending to create a port vs intending to get an existing one

@hemberger
Copy link
Member Author

Yeah, I was thinking the alternative would be to have a real createPort method that fails if the port already exists. But this solution seemed like less trouble. I don't know what is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Page- Page- Page- approved these changes

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hemberger @Page-