chore: Build service clients with exact dependencies #953
Conversation
| import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator | ||
| import kotlin.jvm.optionals.getOrNull | ||
|
|
||
| val SERVICE_CLIENT_JSON_NAME = "Dependencies.json" |
There was a problem hiding this comment.
This type generates a JSON file containing an array with the names of the client's dependencies.
This will be used later when constructing Package.swift.
| @@ -40,7 +40,7 @@ class SwiftDependency( | |||
| "", | |||
| "", | |||
| "", | |||
There was a problem hiding this comment.
Just cleanup below.
| @@ -98,6 +98,7 @@ class SwiftSettings( | |||
| COPYRIGHT_NOTICE, | |||
| VISIBILITY, | |||
| FOR_PROTOCOL_TESTS, | |||
| INTERNAL_CLIENT, | |||
There was a problem hiding this comment.
Forgot to add this when I added the internalClient property... it silences a bunch of Kotlin codegen warnings.
| import software.amazon.smithy.swift.codegen.TestContext | ||
| import software.amazon.smithy.swift.codegen.defaultSettings | ||
| import software.amazon.smithy.swift.codegen.protocolgeneratormocks.MockHTTPAWSJson11ProtocolGenerator | ||
|
|
There was a problem hiding this comment.
Very simple test class for the new service client JSON generator.
| @@ -0,0 +1,39 @@ | |||
| /* | |||
There was a problem hiding this comment.
Suggestion on naming: something like DependencyJSONGenerator is probably more clearer than ServiceClientJSONGenerator. Relevant to all places where this name is used.
There was a problem hiding this comment.
Renamed as suggested.
...t-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/ServiceClientJSONGenerator.kt
Show resolved
Hide resolved
Description of changes
Removes the package manifest generator & replaces it with a generator for JSON that describes dependencies.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.