Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add unexpected FORMAT JSON for not distributed queries #216

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

zenoleg
Copy link
Contributor

@zenoleg zenoleg commented Apr 8, 2024

That changes #190 prevent that queries from being executed:
CREATE FUNCTION ... or DROP FUNCTION ...

The proposed solution in pull request #214 resolves this specific issue. However, it's essential to acknowledge that this fix might introduce potential compatibility issues with existing codebases.

It seems that the changes made in #190 addressed a specific case, but other common scenarios may have been overlooked, so I've implemented an early exit from function when ON CLUSTER does not exist.

@zenoleg
Copy link
Contributor Author

zenoleg commented Apr 8, 2024

@isublimity please, check this PR. It seems you are the only maintainer here

@isublimity isublimity merged commit 5ae1bdd into smi2:master Jul 4, 2024
1 check passed
@isublimity
Copy link
Contributor

Thx!

@zenoleg zenoleg deleted the fix-prepare-write branch July 4, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants