Skip to content

Fix write method format #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix write method format #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Transport/Http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,16 +618,16 @@ private function prepareSelect($sql, $bindings, $whereInFile, $writeToFile = nul
* @return CurlerRequest
* @throws \ClickHouseDB\Exception\TransportException
*/
private function prepareWrite($sql, $bindings = []): CurlerRequest
private function prepareWrite($sql, $bindings = [], ?string $forceResponseFormat = null): CurlerRequest
{
if ($sql instanceof Query) {
return $this->getRequestWrite($sql);
}

$query = $this->prepareQuery($sql, $bindings);

if (strpos($sql, 'CREATE') === 0 || strpos($sql, 'DROP') === 0 || strpos($sql, 'ALTER') === 0) {
$query->setFormat('JSON');
if (null !== $forceResponseFormat) {
$query->setFormat($forceResponseFormat);
}

return $this->getRequestWrite($query);
Expand Down Expand Up @@ -689,9 +689,9 @@ public function setProgressFunction(callable $callback) : void
* @return Statement
* @throws \ClickHouseDB\Exception\TransportException
*/
public function write($sql, array $bindings = [], $exception = true): Statement
public function write($sql, array $bindings = [], $exception = true, ?string $forceResponseFormat = null): Statement
{
$request = $this->prepareWrite($sql, $bindings);
$request = $this->prepareWrite($sql, $bindings, $forceResponseFormat);
$this->_curler->execOne($request);
$response = new Statement($request);
if ($exception) {
Expand Down