Rollback bad commit for setConnectTimeOut

smi2 · Jan 18, 2024 · 66128bf · 66128bf
1 parent a629f30
commit 66128bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -183,9 +183,9 @@ public function setHost($host): void
     /**
      * max_execution_time , in int value (seconds)
      */
-    public function setTimeout(int $timeout): Settings
+    public function setTimeout($timeout): Settings
     {
-        return $this->settings()->max_execution_time($timeout);
+        return $this->settings()->max_execution_time(intval($timeout));
     }
 
     /**

diff --git a/tests/FormatQueryTest.php b/tests/FormatQueryTest.php
@@ -61,7 +61,7 @@ public function testClientTimeoutSettings()
         // max_execution_time - is integer in clickhouse source - Seconds
         $this->client->database('default');
 
-        $timeout = 0.55; // un support, "clickhouse source - Seconds"
+        $timeout = 1.515; // un support, "clickhouse source - Seconds"
         $this->client->setTimeout($timeout);      // 550 ms
         $this->client->select('SELECT 123,123 as ping ')->rows();
         $this->assertSame(intval($timeout), intval($this->client->getTimeout()));
@@ -76,7 +76,6 @@ public function testClientTimeoutSettings()
         $this->client->select('SELECT 123,123 as ping ')->rows();
         $this->assertSame(intval($timeout), $this->client->getTimeout());
 
-
         // getConnectTimeOut is curl, can be float
         $timeout = 5.14;
         $this->client->setConnectTimeOut($timeout);      // 5 seconds