Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash for excludedDirs #401

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix crash for excludedDirs #401

wants to merge 3 commits into from

Conversation

sg3des
Copy link

@sg3des sg3des commented Mar 4, 2016

if run test for dir contains in excludedDirs comes crash goconvey!
i added tiny function, checkExcludedDirs, which checks it.

in my opinion, if the user specified directory for testing - it should be tested, regardless there is or not in the excludes...

if run test for dir contains in excludedDirs comes crash goconvey!
i added tiny function, checkExcludedDirs, which checks it.

in my opinion, if the user specified directory for testing - it should be tested, regardless there is or not in the excludes...
@dlogvinenko
Copy link
Collaborator

@sg3des please add unit tests for your new function: checkExcludedDirs

@sg3des
Copy link
Author

sg3des commented Mar 30, 2016

Of course, tell me where? this (checkExcludedDirs) is internal func, must i create goconvey_test.go in root of package?..

@dlogvinenko
Copy link
Collaborator

@sg3des yes, please create goconvey_test.go in root of package.

"/go/src/package/node_modules/": "node_modules",
}

Convey("Exclude excluded directory for fake pathes", t, func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`+ Convey("Exclude excluded directory for fake pathes paths", t, func() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants