Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve expression editor[fix #252] #306

Merged
merged 2 commits into from
Feb 24, 2022
Merged

feat: improve expression editor[fix #252] #306

merged 2 commits into from
Feb 24, 2022

Conversation

MrWindlike
Copy link
Contributor

@MrWindlike MrWindlike commented Feb 24, 2022 •
edited
Loading

Ref: #252

@MrWindlike
feat: set max height for ExpressionWidget
b8bb57f
@MrWindlike
feat: support tab to change form focus
c46dfb1 
make tab key down in the compact expression editor to change form focus
@netlify
Copy link

netlify bot commented Feb 24, 2022 •
edited
Loading

✔️ Deploy Preview for mystifying-kirch-d00a2f ready!

🔨 Explore the source changes: c46dfb1

🔍 Inspect the deploy log: https://app.netlify.com/sites/mystifying-kirch-d00a2f/deploys/62175f126465700007cc156d

😎 Browse the preview: https://deploy-preview-306--mystifying-kirch-d00a2f.netlify.app/

@MrWindlike MrWindlike changed the title feat: improve expression editor feat: improve expression editor[fix #252] Feb 24, 2022
@github-actions
Copy link

➿ Code coverage

Filename Statements Branches Functions Lines
packages/editor/src/AppModel/utils.ts 100% 75% 100% 100%
packages/editor/src/validator/utils.ts 100% 100% 100% 100%
packages/editor/src/AppModel/FieldModel.ts 96.61% 94.12% 92.86% 96.49%
packages/editor/src/AppModel/TraitModel.ts 100% 75% 100% 100%
packages/editor/src/AppModel/ComponentModel.ts 94.41% 71.15% 100% 97.3%
packages/editor/src/AppModel/AppModel.ts 97.14% 95.83% 96% 97.01%
packages/editor/src/components/StructureTree/ComponentItemView.tsx 11.11% 0% 0% 11.11%
packages/editor/src/operations/type.ts 46.51% 41.67% 41.18% 46.51%
packages/editor/src/operations/leaf/component/removeComponentLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/component/adjustComponentOrderLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/component/createComponentLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/component/modifyComponentIdLeafOperation.ts 50% 50% 33.33% 50%
packages/editor/src/operations/leaf/component/modifyComponentPropertiesLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/constants/index.ts 100% 100% 100% 100%
packages/editor/src/operations/leaf/component/pasteComponentLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/component/moveComponentLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/trait/removeTraitLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/trait/createTraitLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/trait/modifyTraitPropertiesLeafOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/leaf/replaceAppLeafOperation.ts 0% 100% 0% 0%
packages/editor/src/operations/leaf/updateSelectComponentLeafOperation.ts 42.86% 100% 16.67% 42.86%
packages/editor/src/operations/leaf/index.ts 100% 100% 100% 100%
packages/editor/src/operations/branch/component/createComponentBranchOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/branch/component/modifyComponentIdBranchOperation.ts 100% 100% 100% 100%
packages/editor/src/operations/branch/component/removeComponentBranchOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/branch/component/moveComponentBranchOperation.ts 0% 0% 0% 0%
packages/editor/src/components/DataSource/DataSourceItem.tsx 42.86% 0% 0% 42.86%
packages/editor/src/components/DataSource/Api.tsx 12.5% 0% 0% 14.29%
packages/editor/src/components/DataSource/State.tsx 13.33% 0% 0% 15.38%
packages/editor/src/services/enum.ts 100% 100% 100% 100%
packages/editor/src/components/DataSource/DataSource.tsx 7.69% 100% 0% 8%
packages/editor/src/operations/branch/datasource/createDataSourceBranchOperation.ts 0% 0% 0% 0%
packages/editor/src/operations/branch/index.ts 100% 100% 100% 100%
packages/editor/src/operations/index.ts 100% 100% 100% 100%
packages/editor/src/components/StructureTree/DropComponentWrapper.tsx 1.89% 0% 0% 2%
packages/editor/src/components/StructureTree/ComponentTree.tsx 3.85% 0% 0% 4%
packages/editor/src/utils/resolveApplicationComponents.ts 0% 0% 0% 0%
packages/editor/src/components/ErrorBoundary.tsx 0% 0% 0% 0%
packages/editor/src/components/StructureTree/StructureTree.tsx 9.09% 0% 0% 10%
packages/editor/src/components/StructureTree/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentsList/ComponentList.tsx 8.57% 0% 0% 8.57%
packages/editor/src/components/ComponentsList/index.ts 100% 100% 100% 100%
packages/editor/src/components/EditorHeader/EditorHeader.tsx 20% 0% 0% 20%
packages/editor/src/components/EditorHeader/index.ts 100% 100% 100% 100%
packages/editor/src/operations/PasteManager.ts 0% 100% 0% 0%
packages/editor/src/components/KeyboardEventWrapper.tsx 2.44% 0% 0% 2.5%
packages/editor/src/components/CodeEditor/StateViewer.tsx 33.33% 0% 0% 33.33%
packages/editor/src/components/CodeEditor/SchemaEditor.tsx 6.25% 0% 0% 6.25%
packages/editor/src/components/CodeEditor/CssEditor.tsx 4.76% 0% 0% 4.76%
packages/editor/src/constants/ecmascript.ts 100% 100% 100% 100%
packages/editor/src/components/CodeEditor/ExpressionEditor.tsx 7% 0% 0% 7.29%
packages/editor/src/components/CodeEditor/index.ts 100% 100% 100% 100%
packages/editor/src/components/DataSource/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/style.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/JsonSchemaForm/fields.tsx 0% 0% 0% 0%
packages/editor/src/components/ComponentForm/JsonSchemaForm/widgets/ModuleWidget.tsx 5.88% 0% 0% 5.88%
packages/editor/src/components/ComponentForm/JsonSchemaForm/widgets/ExpressionWidget.tsx 8.33% 0% 0% 9.38%
packages/editor/src/components/ComponentForm/JsonSchemaForm/widgets/widgets.tsx 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/JsonSchemaForm/StringField.tsx 11.11% 0% 0% 11.76%
packages/editor/src/components/ComponentForm/JsonSchemaForm/ObjectField.tsx 11.11% 0% 0% 11.11%
packages/editor/src/components/ComponentForm/JsonSchemaForm/ArrayField.tsx 3.85% 0% 0% 3.85%
packages/editor/src/components/ComponentForm/JsonSchemaForm/BooleanField.tsx 14.29% 0% 0% 14.29%
packages/editor/src/components/ComponentForm/JsonSchemaForm/NumberField.tsx 9.09% 0% 0% 9.09%
packages/editor/src/components/ComponentForm/JsonSchemaForm/NullField.tsx 50% 100% 0% 50%
packages/editor/src/components/ComponentForm/JsonSchemaForm/MultiSchemaField.tsx 10.53% 0% 0% 10.53%
packages/editor/src/components/ComponentForm/JsonSchemaForm/TopLevelField.tsx 8.7% 0% 0% 9.09%
packages/editor/src/components/ComponentForm/JsonSchemaForm/UnsupportedField.tsx 33.33% 100% 0% 33.33%
packages/editor/src/components/ComponentForm/JsonSchemaForm/SchemaField.tsx 6.52% 0% 0% 6.67%
packages/editor/src/components/KeyValueEditor.tsx 4.55% 0% 0% 5%
packages/editor/src/components/ComponentForm/EventTraitForm/EventHandlerForm.tsx 1.45% 0% 0% 1.49%
packages/editor/src/components/DataSource/ApiForm/Basic.tsx 4.76% 0% 0% 5.26%
packages/editor/src/components/DataSource/ApiForm/Headers.tsx 12.5% 100% 0% 12.5%
packages/editor/src/components/DataSource/ApiForm/Params.tsx 5.26% 0% 0% 5.26%
packages/editor/src/components/DataSource/ApiForm/Body.tsx 12.5% 100% 0% 12.5%
packages/editor/src/components/DataSource/ApiForm/Error.tsx 33.33% 100% 0% 33.33%
packages/editor/src/components/DataSource/ApiForm/Result.tsx 7.69% 0% 0% 7.69%
packages/editor/src/components/DataSource/ApiForm/Respose.tsx 25% 0% 0% 25%
packages/editor/src/components/DataSource/ApiForm/ApiForm.tsx 3.92% 0% 0% 4.08%
packages/editor/src/components/DataSource/ApiForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/DataSource/StateForm/StateForm.tsx 4% 0% 0% 4.17%
packages/editor/src/components/DataSource/StateForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/EventTraitForm/EventTraitForm.tsx 3.03% 0% 0% 3.57%
packages/editor/src/components/ComponentForm/EventTraitForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/GeneralTraitFormList/AddTraitButton.tsx 7.69% 100% 0% 9.09%
packages/editor/src/components/ComponentForm/GeneralTraitFormList/GeneralTraitForm.tsx 11.11% 0% 0% 11.11%
packages/editor/src/components/ComponentForm/GeneralTraitFormList/GeneralTraitFormList.tsx 7.14% 0% 0% 7.14%
packages/editor/src/components/ComponentForm/GeneralTraitFormList/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/FetchTraitForm/FetchTraitForm.tsx 4.55% 0% 0% 4.88%
packages/editor/src/components/ComponentForm/FetchTraitForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/StyleTraitForm/StyleTraitForm.tsx 2.17% 0% 0% 2.38%
packages/editor/src/components/ComponentForm/StyleTraitForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/ComponentForm/ComponentForm.tsx 5% 0% 0% 5.13%
packages/editor/src/components/ComponentForm/index.ts 100% 100% 100% 100%
packages/editor/src/components/GeneralModal.tsx 50% 0% 0% 50%
packages/editor/src/components/PreviewModal/PreviewModal.tsx 14.29% 100% 0% 20%
packages/editor/src/components/PreviewModal/index.ts 100% 100% 100% 100%
packages/editor/src/components/WarningArea.tsx 5.88% 0% 0% 6.25%
packages/editor/src/components/EditorMaskWrapper/SlotDropArea.tsx 50% 0% 0% 50%
packages/editor/src/components/EditorMaskWrapper/DropSlotMask.tsx 7.69% 0% 0% 8.7%
packages/editor/src/components/EditorMaskWrapper/EditorMask.tsx 16.67% 22.86% 6.67% 17.65%
packages/editor/src/components/EditorMaskWrapper/EditorMaskWrapper.tsx 3.13% 0% 0% 3.13%
packages/editor/src/components/EditorMaskWrapper/index.ts 100% 100% 100% 100%
packages/editor/src/components/Editor.tsx 4.65% 0% 0% 4.65%
packages/editor/src/operations/AppModelManager.ts 21.05% 0% 22.22% 22.86%
packages/editor/src/services/eventBus.ts 100% 100% 100% 100%
packages/editor/src/validator/rules/AllComponentsRules.ts 100% 100% 100% 100%
packages/editor/src/validator/rules/ComponentRules.ts 36.36% 25% 100% 36.36%
packages/editor/src/validator/rules/TraitRules.ts 93.75% 81.82% 100% 93.55%
packages/editor/src/validator/rules/PropertiesRules.ts 97.5% 77.27% 100% 100%
packages/editor/src/validator/rules/index.ts 100% 100% 100% 100%
packages/editor/src/validator/SchemaValidator.ts 98.11% 92.86% 100% 98.11%
packages/editor/src/validator/interfaces.ts 100% 100% 100% 100%
packages/editor/src/validator/index.ts 100% 100% 100% 100%
packages/editor/src/utils/addModuleId.ts 94.44% 77.78% 100% 96.15%
packages/editor/src/services/EditorStore.ts 51.61% 12.5% 35.71% 53.78%
packages/editor/src/services/AppStorage.ts 10.64% 22.22% 5.56% 10.64%
packages/editor/src/init.tsx 80% 0% 40% 80%
packages/editor/src/LocalStorageManager.ts 12.5% 0% 0% 12.5%
packages/editor/src/constants/category.ts 100% 100% 100% 100%
packages/editor/src/index.ts 100% 100% 100% 100%
packages/runtime/src/utils/watchReactivity.ts 2.15% 0% 0% 2.6%
packages/runtime/src/utils/isNumeric.ts 100% 50% 100% 100%
packages/runtime/src/constants.ts 100% 100% 100% 100%
packages/runtime/src/services/StateManager.ts 73.2% 58.33% 45% 73.12%
packages/runtime/src/utils/resolveChildrenMap.ts 100% 100% 100% 100%
packages/runtime/src/services/RuntimeAppSchemaManager.ts 92.86% 83.33% 100% 92.86%
packages/core/src/version.ts 83.33% 50% 100% 83.33%
packages/core/src/application.ts 91.67% 66.67% 100% 91.67%
packages/runtime/src/utils/parseTypeBox.ts 81.25% 74.07% 100% 81.25%
packages/core/src/trait.ts 100% 100% 100% 100%
packages/core/src/component.ts 100% 100% 100% 100%
packages/runtime/src/components/_internal/Text.tsx 100% 75% 100% 100%
packages/core/src/scope.ts 100% 100% 100% 100%
packages/editor/src/vite-env.d.ts 100% 100% 100% 100%
packages/editor/src/playground.tsx 0% 0% 0% 0%
packages/editor/src/components/Explorer/Explorer.tsx 0% 0% 0% 0%
packages/editor/src/components/Explorer/ExplorerTree.tsx 0% 0% 0% 0%
packages/editor/src/components/Explorer/ExplorerForm/ModuleMetaDataForm.tsx 0% 100% 0% 0%
packages/editor/src/components/Explorer/ExplorerForm/AppMetaDataForm.tsx 0% 100% 0% 0%
packages/editor/src/components/Explorer/ExplorerForm/ExplorerForm.tsx 0% 0% 0% 0%
packages/editor/src/main.tsx 0% 0% 0% 0%
packages/editor/src/components/Explorer/index.ts 100% 100% 100% 100%
packages/editor/src/components/Explorer/ExplorerForm/index.ts 100% 100% 100% 100%
packages/editor/src/global.d.ts 100% 100% 100% 100%
packages/editor/src/AppModel/IAppModel.ts 100% 100% 100% 100%
packages/editor/src/constants/layout.ts 0% 100% 100% 0%
packages/editor/src/types.ts 100% 100% 100% 100%
packages/runtime/src/index.ts 0% 0% 0% 0%
packages/runtime/src/vite-env.d.ts 100% 100% 100% 100%
packages/runtime/src/App.tsx 0% 0% 0% 0%
packages/runtime/src/services/handler.ts 0% 100% 0% 0%
packages/runtime/src/utils/encodeDragDataTransfer.ts 0% 100% 0% 0%
packages/runtime/src/types/index.ts 100% 100% 100% 100%
packages/runtime/src/services/apiService.ts 0% 0% 0% 0%
packages/runtime/src/services/DebugComponents.tsx 0% 100% 0% 0%
packages/runtime/src/services/Registry.tsx 0% 0% 0% 0%
packages/runtime/src/utils/shallowCompareArray.ts 0% 0% 0% 0%
packages/runtime/src/utils/buildKit.ts 0% 100% 0% 0%
packages/runtime/src/utils/initStateAndMethod.ts 0% 0% 0% 0%
packages/runtime/src/types/component.ts 100% 100% 100% 100%
packages/runtime/src/types/module.ts 0% 100% 100% 0%
packages/runtime/src/types/traitPropertiesSchema.ts 0% 100% 100% 0%
packages/runtime/src/types/application.ts 100% 100% 100% 100%
packages/runtime/src/types/trait.ts 100% 100% 100% 100%
packages/runtime/src/types/validResultSchema.ts 0% 100% 100% 0%
packages/runtime/src/components/core/Dummy.tsx 0% 100% 0% 0%
packages/runtime/src/traits/core/Fetch.tsx 0% 0% 0% 0%
packages/runtime/src/components/_internal/GridLayout.tsx 0% 0% 0% 0%
packages/runtime/src/components/core/ModuleContainer.tsx 0% 0% 0% 0%
packages/runtime/src/components/core/GridLayout.tsx 0% 0% 0% 0%
packages/runtime/src/components/core/Text.tsx 0% 100% 0% 0%
packages/runtime/src/components/_internal/ModuleRenderer.tsx 0% 0% 0% 0%
packages/runtime/src/components/_internal/ImplWrapper.tsx 0% 0% 0% 0%
packages/runtime/src/traits/core/Hidden.tsx 0% 0% 0% 0%
packages/runtime/src/traits/core/Slot.tsx 0% 100% 0% 0%
packages/runtime/src/traits/core/Style.tsx 0% 100% 0% 0%
packages/runtime/src/traits/core/State.tsx 0% 0% 0% 0%
packages/runtime/src/traits/core/ArrayState.tsx 0% 0% 0% 0%
packages/runtime/src/traits/core/Event.tsx 0% 0% 0% 0%
packages/runtime/src/traits/core/Validation.tsx 0% 0% 0% 0%
packages/runtime/src/components/core/Router/index.tsx 0% 100% 0% 0%
packages/runtime/src/components/core/Router/matcher.ts 0% 0% 0% 0%
packages/runtime/src/components/core/Router/hooks.tsx 0% 0% 0% 0%
packages/runtime/src/components/core/Router/component.tsx 0% 0% 0% 0%
packages/core/src/index.ts 100% 100% 100% 100%
packages/core/src/module.ts 0% 0% 0% 0%
packages/core/src/metadata.ts 100% 100% 100% 100%
packages/core/src/method.ts 100% 100% 100% 100%

@Yuyz0112 Yuyz0112 merged commit df5409c into main Feb 24, 2022
xzdry pushed a commit that referenced this pull request Nov 3, 2022
@Yuyz0112
Merge pull request #306 from webzard-io/feat/windlike-patch
fbf4208 
feat: improve expression editor[fix #252]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuyz0112 Yuyz0112 Yuyz0112 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrWindlike @Yuyz0112