Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Form #252

Closed
7 of 10 tasks
tanbowensg opened this issue Jan 30, 2022 · 4 comments
Closed
7 of 10 tasks

Improve Form #252

tanbowensg opened this issue Jan 30, 2022 · 4 comments
Assignees
Milestone

Comments

@tanbowensg
Copy link
Collaborator

tanbowensg commented Jan 30, 2022

What problem does this feature solve?
Before solving this issue, we should design the new spec of the property. #251
related issue: #211

The new Form should improve these points:

  • Better array and object editor. Array editor should support different types of item.
  • The special forms like FetchTraitForm, EventHanlderForm should use the same form widgets as other normal forms.
  • The Form widgets can collapse.
  • The Form widgets can be grouped and ordered.
  • The Form widgets can display title, description...
  • After clicking validation error message, the form auto scroll to the related input. #250 Can auto-scroll to an input.
  • Conditional Form. Mainly used in table column form.
  • Prevent recursively render form fields for some property, like data in table. Set max height for expression editor.
  • Press tab to switch input.
  • Value type may change after switch to or from ExpressionEditor.

What does the proposed API look like?

@tanbowensg tanbowensg added feature New feature or request editor ui-design labels Jan 30, 2022
@tanbowensg tanbowensg added this to the v1.0.0 milestone Jan 30, 2022
@Yuyz0112
Copy link
Contributor

Better array and object editor. Array editor should support different types of elements(string, object, any...)

What's the expectation of this improvement?

Currently, the ArrayField consists of some array-related operation UI and bypass nested schema to a SchemaField, which will recursively render form fields by the schema.

@tanbowensg tanbowensg modified the milestones: v1.0.0, v0.9 Feb 8, 2022
@tanbowensg tanbowensg modified the milestones: v0.9, v1.0.0 Feb 15, 2022
@tanbowensg
Copy link
Collaborator Author

tanbowensg commented Feb 21, 2022

Can we support conditional form? For example in table column form, a column has many types and each type has its own property. Can we show different fields according to the value of type?

@tanbowensg tanbowensg modified the milestones: v1.0.0, v0.5 Feb 23, 2022
@tanbowensg tanbowensg assigned MrWindlike and xzdry and unassigned xzdry Feb 23, 2022
@MrWindlike
Copy link
Contributor

The special forms like FetchTraitForm, EventHanlderForm should use the same form widgets as other normal forms.

@tanbowensg Can the PR's changes meet this point? If yes, I mark it to complete.

@tanbowensg
Copy link
Collaborator Author

The remaining issues has other individual issues, so I close this issue.

xzdry pushed a commit that referenced this issue Nov 3, 2022
feat: improve expression editor[fix #252]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants