Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKS-1390: Optimize the creation of virtual machines when insufficient storage detected for ELF cluster #170

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

haijianyang
Copy link
Contributor

@haijianyang haijianyang commented Jan 24, 2024

Issue SKS-1390

集群存储不足时,创建节点 VM 任务不断重试,创建出多个重复的同名 volume。

Change

SMTX OS 6.0 未复现多个重复的同名 volume,因此不需处理。

Test

  1. 把集群的存储资源机会消耗完
image
  1. 创建任意数量节点的集群,观察到存储不足导致节点无法创建,并每隔五分钟后允许重试
    image

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.79%. Comparing base (66ba3c9) to head (209a0c8).
Report is 1 commits behind head on master.

❗ Current head 209a0c8 differs from pull request most recent head bfc37cf. Consider uploading reports for the commit bfc37cf to get more accurate results

Files Patch % Lines
pkg/service/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   59.60%   59.79%   +0.19%     
==========================================
  Files          20       20              
  Lines        3656     3699      +43     
==========================================
+ Hits         2179     2212      +33     
- Misses       1329     1339      +10     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

controllers/tower_cache.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_test.go Show resolved Hide resolved
controllers/tower_cache_test.go Outdated Show resolved Hide resolved
@haijianyang haijianyang merged commit 1ed0e13 into smartxworks:master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants