-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKS-2345: Add support for system disk expansion #169
Conversation
@Levi080513 帮忙review下 |
👌 |
} | ||
} | ||
if agentJob == nil { | ||
agentJob, err = hostagent.AddNewDiskCapacityToRoot(ctx, kubeClient, ctx.ElfMachine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些 agentJob 要不要考虑在执行完成后进行清理?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以删除,agent 也许会支持自动清理。
9f1f8ed
to
617f114
Compare
@haijianyang 集群的状态检查可以在KSC webhook中做吗?这样可以直接把错误返回给UI。 |
可以在 webhook 拦截,检查磁盘扩容的时候的集群状态。但如果集群在扩容的时候滚动了,这个没有办法反馈。 |
617f114
to
bfe3225
Compare
3513be2
to
df8ea6f
Compare
b29390b
to
b97e549
Compare
04a2f95
to
479fe15
Compare
|
||
// Agent needs to wait for the node exists before it can run and execute commands. | ||
if machineutil.IsUpdatingElfMachineResources(ctx.ElfMachine) && | ||
ctx.Machine.Status.NodeInfo == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需不需要在 sks-controller-manager 判断一下 hostAgent 有没有部署且状态是否正常。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有必要吧,这样就依赖这个服务了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
热扩容功能现阶段不是强依赖 hostAgent 么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果按照这个逻辑,那么 CAPE 依赖了其他服务,也都需要确认服务在正常运行?
如果要判断 agent 是否安装,应该是在上游判断吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的意思是需不需要在 KSC 加对应的处理。虚拟机集群 1.3 会默认安装 hostAgent 么? @huaqing1994
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在虚拟机集群没有默认安装。
我觉得对于 CAPE 来说,是可以不检查,host-config-agent 的 CR 能创建出来就 OK 了。
如果虚拟机热更新功能要进,感觉得所有集群都默认安装 host-config-agent。
不然要在 KSC 做前置判断,有点麻烦。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KSC webhook 检查是否 host-config-agent 安装以及状态正常?如果没有安装或者状态不正常,集群最终会处于 failed 么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webhook 能判断出所有热更新的情况就可以,怕以后热更新类型多了。
没安装或状态不对,CAPE 这边的处理就完不成,KSC 那边是会 Failed。
902e023
to
f37521f
Compare
f37521f
to
b8f98ae
Compare
|
兼容原有磁盘容量设置为 0,如果磁盘容量为 0,表示容量和虚拟机模板一样。 |
aafe857
to
a54b5c7
Compare
Issue
支持虚拟机磁盘扩容
Change
磁盘扩容技术文档
待讨论:
Test
观察到创建出来的节点虚拟机的磁盘容量符合预期
集群创建出来后,将磁盘容量从 220G -> 240G,观察到触发了磁盘扩容: