SKS-1573: Refactor available hosts and vm migration code #130

haijianyang · 2023-07-20T07:22:50Z

问题

优化放置组相关代码

CAPE 1.2.10代码也还是用 kcp.Status.Replicas 来判断是否是滚动更新中，并不准确，需要改成前天说的用conditions来判断
1st CP 是否需要做热迁移，只需要条件1成立时才做，不需要提前判断、也不需要提前找出迁移的target host
GetAvailableHosts 按昨晚的讨论需要改进优化，让代码更准确更简洁

解决

使用 RollingUpdateInProgressReason 判断 KCP 是否正在升级
把找出迁移的 target host 的代码放到 joinPlacementGroup
可用主机使用 Hosts collection 封装相关的操作逻辑

其他改动：移除了限制同时只能迁移一个虚拟机的逻辑。

测试

3 主机 ELF 集群，3 CP + 1 Worker 集群，经过三次集群升级验证，使用脚本每秒更新第一个升级的 CP，没有发现虚拟机迁移情况。

测试版本在 E2E 中验证完成。

codecov · 2023-07-20T07:30:25Z

Codecov Report

Merging #130 (a18cc54) into master (ac6b074) will increase coverage by 1.60%.
The diff coverage is 81.04%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   53.66%   55.26%   +1.60%     
==========================================
  Files          15       16       +1     
  Lines        2581     2602      +21     
==========================================
+ Hits         1385     1438      +53     
+ Misses       1084     1045      -39     
- Partials      112      119       +7

Files Changed	Coverage Δ
controllers/elfmachine_controller.go	`73.53% <0.00%> (+0.91%)`	⬆️
controllers/vm_limiter.go	`100.00% <ø> (ø)`
pkg/service/vm.go	`0.00% <0.00%> (ø)`
pkg/service/util.go	`21.69% <40.00%> (-0.68%)`	⬇️
...ntrollers/elfmachine_controller_placement_group.go	`71.39% <74.79%> (-1.71%)`	⬇️
pkg/service/collections.go	`96.25% <96.25%> (ø)`

jessehu · 2023-07-31T11:57:22Z

controllers/elfmachine_controller_placement_group.go

@@ -170,7 +170,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex

 	// KCP is not in scaling down/rolling update.
 	if !(kcputil.IsKCPRollingUpdateFirstMachine(kcp) || kcputil.IsKCPInScalingDown(kcp)) {


这里和上周五讨论的 MHC和KCP RollingOut交叉在一起的问题相关： https://smartx1.slack.com/archives/C04288LAHTP/p1690784537848789?thread_ts=1690455013.021899&cid=C04288LAHTP

当前的判断条件如下。kcp.Status.UpdatedReplicas == 1 表示已经创建了一个并且只有一个新的CP Machine，但此时Machine对应的VM并不一定创建出来了(因为此时有一个旧CP Node not ready，reconcile 卡在这里)。

func IsKCPRollingUpdateFirstMachine(kcp *controlplanev1.KubeadmControlPlane) bool { - return *kcp.Spec.Replicas < kcp.Status.Replicas && kcp.Status.UpdatedReplicas == 1 + return IsKCPRollingUpdate(kcp) && kcp.Status.UpdatedReplicas == 1 }

如果把约束条件kcp.Status.UpdatedReplicas == 1去掉，能否解决这个场景的问题？有没有副作用？
去掉后的效果应该是这样：只要KCP处于RollingUpdate状态，如果当前放置组有空位，就把新CP VM加入放置组；如果没有空位，就把CP VM放置在最后一个被删除的旧VM所在Host(暂时不加入放置组)
@haijianyang

这个 PR 先不处理其他改动吧。先做优化再处理其他的。

jessehu · 2023-07-31T12:10:46Z

controllers/elfmachine_controller_placement_group.go

@@ -170,7 +170,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex

 	// KCP is not in scaling down/rolling update.


这个注释需要改得更准确点：
// When KCP is not in scaling down and it's not rolling update the 1st CP Machine, just return since the placement group is full.

jessehu · 2023-07-31T12:13:16Z

controllers/elfmachine_controller_placement_group.go

@@ -213,7 +213,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex

 	// KCP is in rolling update.


// When the PlacementGroup is full and it's rolling update the 1st CP Machine and, place the VM on the target host without joining the PlacementGroup and power it on. After other CP Machine are rolled out successfully, add this 1st CP VM into the PlacementGroup.

jessehu · 2023-07-31T12:27:50Z

controllers/elfmachine_controller_placement_group.go

@@ -213,7 +213,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex

 	// KCP is in rolling update.

-	if !service.ContainsUnavailableHost(hosts, usedHostsByPG.UnsortedList(), *service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB)) &&
+	if usedHostsByPG.Len() == usedHostsByPG.Available(*service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB)).Len() &&


这两个if分别是用来判断什么的？上次讨论后有点忘记了。

这里的逻辑可能需要调整。

现在代码的逻辑是：滚动更新的时候需要每个主机都是可用的，且内存足够创建一个 CP。然后选择最老的一个 CP 的所在主机赋值给第一个滚动更新的 CP。

滚动更新的时候需要每个主机都是可用的，且内存足够创建一个 CP。

改成这样：只需要为这个CP VM选中的目标主机有足够内存就够了？

上午讨论的结果，保持现状：https://smartx1.slack.com/archives/C04288LAHTP/p1690864825115779?thread_ts=1690512394.197659&cid=C04288LAHTP

jessehu · 2023-07-31T12:29:18Z

controllers/elfmachine_controller_placement_group.go

@@ -225,7 +225,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex
 		return pointer.String(hostID), err
 	}

-	ctx.Logger.V(1).Info("The placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHostSet.UnsortedList(), "usedHostsByPG", usedHostsByPG.UnsortedList())
+	ctx.Logger.V(1).Info("The placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String())


这条log msg和 173行的一模一样，不方便区分，如果这两处场景不是一样的，就需要加些带特征描述的msg文字

jessehu · 2023-07-31T12:30:57Z

controllers/elfmachine_controller_placement_group.go

@@ -213,7 +213,7 @@ func (r *ElfMachineReconciler) preCheckPlacementGroup(ctx *context.MachineContex

 	// KCP is in rolling update.

-	if !service.ContainsUnavailableHost(hosts, usedHostsByPG.UnsortedList(), *service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB)) &&
+	if usedHostsByPG.Len() == usedHostsByPG.Available(*service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB)).Len() &&
 		int(*kcp.Spec.Replicas) == usedHostsByPG.Len() {
 		// Only when KCP is in rolling update and the placement group is full


这两行注释可以删除，统一加到214行的注释中。

jessehu · 2023-07-31T12:52:11Z

pkg/service/collections.go

+}
+
+// Available returns a Hosts with available hosts.
+func (s Hosts) Available(memory int64) Hosts {


建议改个名字：
// GetHostsWithEnoughMemory returns a Hosts containing the available host which has allocatable memory no less than the specified memory.
GetHostsWithEnoughMemory(memory int64) Hosts {

这里不止判断内存，使用的是 Tower 可用主机判断。

嗯，那也没错，我调整下func描述就行

FilterAvailableHostsWithEnoughMemory(memory int32)

jessehu · 2023-07-31T12:52:54Z

pkg/service/mock_services/vm_mock.go

@@ -1,5 +1,5 @@
 // Code generated by MockGen. DO NOT EDIT.
-// Source: github.com/smartxworks/cluster-api-provider-elf/pkg/service/vm.go
+// Source: /root/github/cluster-api-provider-elf/pkg/service/vm.go


这个改动好像不对？

jessehu · 2023-07-31T13:02:13Z

pkg/util/kcp/kcp.go

+// When all machines are up to date, KCP controller marks MachinesSpecUpToDateCondition to true.
+//
+// For more information about KCP MachinesSpecUpToDateCondition and RollingUpdateInProgressReason, refer to https://github.com/kubernetes-sigs/cluster-api/blob/main/api/v1beta1/condition_consts.go
+func IsKCPRollingUpdate(kcp *controlplanev1.KubeadmControlPlane) bool {


下面的IsKCPInScalingDown() 使用了In，IsKCPRollingUpdate() 没带In，两者统一下风格

jessehu · 2023-07-31T13:02:30Z

pkg/util/kcp/kcp.go

+//
+// For more information about KCP MachinesSpecUpToDateCondition and RollingUpdateInProgressReason, refer to https://github.com/kubernetes-sigs/cluster-api/blob/main/api/v1beta1/condition_consts.go
+func IsKCPRollingUpdate(kcp *controlplanev1.KubeadmControlPlane) bool {
+	return conditions.IsFalse(kcp, controlplanev1.MachinesSpecUpToDateCondition) &&


这个直接使用ReadyCondition就可以吧？另外字面上看 MachinesSpecUpToDateCondition 只表示Spec是UpToDate，并不代表KCP已经Ready(也就是RollingUpdate已经完成)

conditions.SetSummary(kcp, conditions.WithConditions( controlplanev1.MachinesCreatedCondition, controlplanev1.MachinesSpecUpToDateCondition, controlplanev1.ResizedCondition, controlplanev1.MachinesReadyCondition, controlplanev1.AvailableCondition, controlplanev1.CertificatesAvailableCondition, ), )

可以改，但是会有误判的风险。具体看一下之前讨论的 WithConditions。

我是觉得 MachinesSpecUpToDateCondition 在此func的含义中不靠谱

haijianyang · 2023-08-02T06:56:43Z

本地升级验证正常。准备发测试版到 E2E跑。

haijianyang · 2023-08-03T03:07:21Z

https://smartx1.slack.com/archives/C04288LAHTP/p1690784537848789?thread_ts=1690455013.021899&cid=C04288LAHTP 验证，发现以下问题，yishanreproduce-controlplane-f86p6（滚动更新的第二个 CP）没有通过虚拟机迁移的判断逻辑，导致不能被迁移。

环境在 SKS-1656

			targetHost := availableHosts.UnsortedList()[0]
			usedHostsByPG := sets.Set[string]{}
			for i := 0; i < len(cpElfMachines); i++ {
				if ctx.ElfMachine.Name != cpElfMachines[i].Name &&
					cpElfMachines[i].Status.PlacementGroupRef == *placementGroup.ID &&
					cpElfMachines[i].CreationTimestamp.After(ctx.ElfMachine.CreationTimestamp.Time) {
					usedHostsByPG.Insert(cpElfMachines[i].Status.HostServerRef)
				}
			}

haijianyang · 2023-08-03T03:10:05Z

E2E 中发现了 panic 现象，目前只出现了1次（和目前的 PR 没有关系），
ctx.Logger.V(1).Info("The availableHosts for migrating the VM", "hosts", availableHosts.String(), "vmHost", *vm.Host.ID)
应该是某些特点条件下 vm.Host 为 nil。
https://smartx1.slack.com/archives/C04FAS9EUKV/p1690984072916259

jessehu · 2023-08-03T06:10:25Z

controllers/elfmachine_controller_placement_group.go

+
+	ok, message := service.IsAvailableHost(host, *service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB))
+	if ok {
+		ctx.Logger.Info("Selected the host server for VM since the placement group is full", "hostID", *vm.Host.ID, "vmRef", ctx.ElfMachine.Status.VMRef)


修改下msg："Select a host to power on the VM since the placement group is full"

这里和其他打印vm.Host.ID的地方能显示出host name 吗？

jessehu · 2023-08-03T06:29:49Z

pkg/service/collections.go

 	return s.Filter(func(h *models.Host) bool {
 		ok, _ := IsAvailableHost(h, memory)
 		return ok
 	})
 }

+// FilterUnavailableHostsWithoutEnoughMemory returns a Hosts containing the unavailable host which has allocatable memory less than the specified memory.


调整如下：

// FilterUnavailableHostsOrWithoutEnoughMemory returns a Hosts containing the unavailable hosts or available hosts whose available memory is less than the specified memory. func (s Hosts) FilterUnavailableHostsOrWithoutEnoughMemory(memory int64) Hosts {

jessehu · 2023-08-03T06:33:50Z

controllers/elfmachine_controller_placement_group.go

-	// When KCP is not in scaling down and it's not rolling update the 1st CP Machine, just return since the placement group is full.
-	if !(kcputil.IsKCPRollingUpdateFirstMachine(kcp) || kcputil.IsKCPInScalingDown(kcp)) {
-		ctx.Logger.V(1).Info("KCP is not in scaling down and it's not rolling update the 1st CP Machine, the placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String())
+	// When KCP is not in rolling update and it's not in scaling down, just return since the placement group is full.


-> // When KCP is not in rolling update and not in scaling down

jessehu · 2023-08-03T06:34:22Z

controllers/elfmachine_controller_placement_group.go

-		ctx.Logger.V(1).Info("KCP is not in scaling down and it's not rolling update the 1st CP Machine, the placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String())
+	// When KCP is not in rolling update and it's not in scaling down, just return since the placement group is full.
+	if !kcputil.IsKCPInRollingUpdate(kcp) && !kcputil.IsKCPInScalingDown(kcp) {
+		ctx.Logger.V(1).Info("KCP is not in rolling update and it's not in scaling down, the placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String())


msg修改同上

jessehu · 2023-08-03T06:43:38Z

controllers/elfmachine_controller_placement_group.go

-		if err != nil || hostID == "" {
-			return nil, err
-		}
+	usedAndUnavailableHostsByPG := usedHostsByPG.FilterUnavailableHostsWithoutEnoughMemory(*service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB))


改个简单的名字：usedAndUnavailableHostsByPG -> unusableHosts

ctx.Logger.V(1).Info("KCP is in rolling update, the placement group is full and has unusable hosts, will wait for enough available hosts"

jessehu · 2023-08-03T07:07:08Z

controllers/elfmachine_controller_placement_group.go

-				usedHostsByPG.Len() == usedHostsByPG.Available(*service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB)).Len() &&
-				int(*kcp.Spec.Replicas) == usedHostsByPG.Len() {
-				ctx.Logger.Info("The placement group is full and KCP is in rolling update, skip adding VM to the placement group", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)
+			// In this case machine created by KCP rolling update can be powered on without being added to the placement group.


这个comment改成：
// In this case the machine created by KCP rolling update can be powered on without being added to the placement group, so return true and nil to let reconcileVMStatus() power it on.

jessehu · 2023-08-03T07:18:05Z

controllers/elfmachine_controller_placement_group.go

@@ -415,14 +418,17 @@ func (r *ElfMachineReconciler) joinPlacementGroup(ctx *context.MachineContext, v

 			// Only when the KCP is in rolling update, the VM is stopped, and all the hosts used by the placement group are available,
 			// will the upgrade be allowed with the same number of hosts and CP nodes.


按slack中沟通，420行可以删除

jessehu · 2023-08-03T07:42:05Z

controllers/elfmachine_controller_placement_group.go

+			if kcputil.IsKCPInRollingUpdate(kcp) && *vm.Status == models.VMStatusSTOPPED {
+				usedAndUnavailableHostsByPG := usedHostsByPG.FilterUnavailableHostsWithoutEnoughMemory(*service.TowerMemory(ctx.ElfMachine.Spec.MemoryMiB))
+				if usedAndUnavailableHostsByPG.IsEmpty() {
+					ctx.Logger.Info("KCP is in rolling update, the placement group is full and has no unavailable hosts, skip adding VM to the placement group", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)


这个log也改成如下：
"KCP is in rolling update, the placement group is full and has no unusable hosts, so skip adding VM to the placement group and power it on"

jessehu · 2023-08-03T07:42:28Z

controllers/elfmachine_controller_placement_group.go


-				return true, nil
+				ctx.Logger.Info("KCP is in rolling update, the placement group is full and has unavailable hosts, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)


unavailable hosts -> unusable hosts
wait for -> so wait for

jessehu · 2023-08-03T07:44:32Z

controllers/elfmachine_controller_placement_group.go

-				return true, nil
+				ctx.Logger.Info("KCP is in rolling update, the placement group is full and has unavailable hosts, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)
+
+				return false, nil
 			}

 			if *vm.Status == models.VMStatusRUNNING || *vm.Status == models.VMStatusSUSPENDED {


什么情况下会走到 434 行？VM已经在放置组中还是不在？

滚动更新第一个 CP 就不需要进入放置组开机。

前面已经有判断是否在放置组，在放置不会走到这里。
走到这里表示放置组已经满了，没有可用主机，但是当前 VM 已经开机了，直接返回。

jessehu · 2023-08-03T08:29:26Z

controllers/elfmachine_controller_placement_group.go


 				return true, nil
 			}

 			// KCP is scaling out or being created.
-			ctx.Logger.V(1).Info("The placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHostSet.UnsortedList(), "usedHostsByPG", usedHostsByPG.UnsortedList(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)
+			ctx.Logger.V(1).Info("The placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", *vm.ID)


这个log改成 "KCP is in scaling up or being created, the placement group is full, so wait for enough available hosts"

jessehu · 2023-08-04T04:39:38Z

controllers/elfmachine_controller_placement_group.go

+				return false, err
+			}
+
+			targetHost := availableHosts.UnsortedList()[0]


这行移到480行之前(在此行之前没有使用)

jessehu · 2023-08-04T05:18:46Z

controllers/elfmachine_controller_placement_group.go

-		ctx.Logger.V(1).Info("The placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHostSet.UnsortedList(), "usedHostsByPG", usedHostsByPG.UnsortedList())
+	// When KCP is not in rolling update and not in scaling down, just return since the placement group is full.
+	if !kcputil.IsKCPInRollingUpdate(kcp) && !kcputil.IsKCPInScalingDown(kcp) {
+		ctx.Logger.V(1).Info("KCP is not in rolling update and not in scaling down, the placement group is full, wait for enough available hosts", "placementGroup", *placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String())


原来的 wait for enough available hosts 都统一改成这个吧 "so wait for enough available hosts" ；加个so 表示前面是因，后面是果。

jessehu · 2023-08-04T07:54:14Z

controllers/elfmachine_controller_placement_group.go

@@ -460,24 +463,35 @@ func (r *ElfMachineReconciler) joinPlacementGroup(ctx *context.MachineContext, v
 				return true, nil
 			}

-			// The 1st new CP ElfMachine should wait for other new CP ElfMachines to join the target PlacementGroup.
+			// The new CP ElfMachine should wait for other new CP ElfMachines to join the target PlacementGroup.


// The new CP ElfMachine
->
// The powered on CP ElfMachine which is not in the PlacementGroup

jessehu · 2023-08-04T07:57:43Z

controllers/elfmachine_controller_placement_group.go

+			// and kcp.Status.UnavailableReplicas == 0.
+			// So we need to check if the number of CP ElfMachine is equal to kcp.Spec.Replicas.
+			if len(cpElfMachines) != int(*kcp.Spec.Replicas) {
+				ctx.Logger.Info("The number of CP ElfMachine does not match the expected", "kcp", formatKCP(kcp), "cpElfMachines", cpElfMachineNames)


这个也使用V(1)吧

jessehu · 2023-08-04T08:35:08Z

controllers/elfmachine_controller_placement_group.go

+			// This is the last CP ElfMachine (i.e. the 1st new CP ElfMachine) which has not been added into the target PlacementGroup.
+			// Migrate this VM to the target host, then it will be added into the target PlacementGroup.
+
+			ctx.Logger.V(1).Info("Start migrateVM since KCP is not in rolling update process", "targetHost", formatHost(targetHost))


这里msg改成 Start migrating VM

jessehu

Great!

haijianyang requested a review from jessehu July 20, 2023 07:22

haijianyang mentioned this pull request Jul 26, 2023

SKS-1636: Bump CAPI to v1.4.5 #132

Merged

Refactor available hosts and vm migration code

8037ba1

haijianyang force-pushed the opt-pg branch from c7c7eea to 8037ba1 Compare July 26, 2023 03:50

haijianyang temporarily deployed to default July 26, 2023 03:56 — with GitHub Actions Inactive

jessehu reviewed Jul 31, 2023

View reviewed changes

Fix comment

d881627

haijianyang requested a review from jessehu August 2, 2023 06:56

Update

b2d4621

haijianyang force-pushed the opt-pg branch from 15397ed to b2d4621 Compare August 3, 2023 03:47

jessehu reviewed Aug 3, 2023

View reviewed changes

haijianyang added 3 commits August 3, 2023 05:21

Fix comment

8c664ed

Fix comment

7b33792

Add formatHost

52dd4ad

jessehu reviewed Aug 4, 2023

View reviewed changes

Fix migration

9cd49cb

jessehu reviewed Aug 4, 2023

View reviewed changes

Fix comment

a18cc54

haijianyang requested a review from jessehu August 4, 2023 09:51

jessehu approved these changes Aug 4, 2023

View reviewed changes

haijianyang merged commit 4023d9f into smartxworks:master Aug 4, 2023
3 checks passed

		@@ -170,7 +170,7 @@ func (r ElfMachineReconciler) preCheckPlacementGroup(ctx context.MachineContex

		// KCP is not in scaling down/rolling update.
		if !(kcputil.IsKCPRollingUpdateFirstMachine(kcp) \|\| kcputil.IsKCPInScalingDown(kcp)) {

		@@ -213,7 +213,7 @@ func (r ElfMachineReconciler) preCheckPlacementGroup(ctx context.MachineContex

		// KCP is in rolling update.

		@@ -415,14 +418,17 @@ func (r ElfMachineReconciler) joinPlacementGroup(ctx context.MachineContext, v

		// Only when the KCP is in rolling update, the VM is stopped, and all the hosts used by the placement group are available,
		// will the upgrade be allowed with the same number of hosts and CP nodes.


		return true, nil
		ctx.Logger.Info("KCP is in rolling update, the placement group is full and has unavailable hosts, wait for enough available hosts", "placementGroup", placementGroup.Name, "availableHosts", availableHosts.String(), "usedHostsByPG", usedHostsByPG.String(), "vmRef", ctx.ElfMachine.Status.VMRef, "vmId", vm.ID)

SKS-1573: Refactor available hosts and vm migration code #130

SKS-1573: Refactor available hosts and vm migration code #130

Conversation

haijianyang commented Jul 20, 2023 • edited Loading

问题

解决

测试

codecov bot commented Jul 20, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessehu Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haijianyang commented Aug 2, 2023

haijianyang commented Aug 3, 2023 • edited Loading

haijianyang commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessehu left a comment

Choose a reason for hiding this comment

haijianyang commented Jul 20, 2023 •

edited

Loading

codecov bot commented Jul 20, 2023 •

edited

Loading

jessehu Jul 31, 2023 •

edited

Loading

haijianyang commented Aug 3, 2023 •

edited

Loading