Experimental LOOPP-enabling adjustment to MaxDurationQuery #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
May 12, 2023
| if maxDurationQuery == 0 { | ||
| // Some feeds are configured to zero due to the in-memory implementation of Query being a no-op. | ||
| // This is incompatible with GRPC/LOOPPs, which short circuits on the cancelled context, so we override the value. | ||
| maxDurationQuery = 500 * time.Millisecond // TODO from config? |
There was a problem hiding this comment.
100ms is passing the smoke tests.
Suggested change
| maxDurationQuery = 500 * time.Millisecond // TODO from config? | |
| maxDurationQuery = 100 * time.Millisecond // TODO from config? |
We can likely go even lower.
There was a problem hiding this comment.
Applied this and rebased over here: #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.