Issue#56 response listener hangs #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes changes to code introduced in #36. Things to note: 1. 2 confirmations is a sensible default but have made 1 to reduce friction for devs so it works out of the box with local functions testnet. 2. Alternative could be to check inside `listenForResponseFromTransaction()` for ChainID 1337 (local funcs testnet) and then change the default confirmations to 1. 3. DevX Improvement: . README updates and added inline docs to the function so that it shows on however in the IDE
KuphJr
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Looks good!
However, you will need to generate a changeset for this. All you need to do is run yarn changeset and follow the instructions. This will be a simple patch release.
Then you can commit the generated changeset file. Once a PR with a changeset is merged to main, it will trigger a new PR to be opened which will publish the release when it is merged.
|
KuphJr
approved these changes
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested Fix for Issue: #56
Makes changes to code introduced in PR #36
Things to note:
1. 2 confirmations is a sensible default but have made 1 to reduce friction for devs so it works out of the box with local functions testnet.
2. Alternative could be to check inside
listenForResponseFromTransaction()for ChainID 1337 (local funcs testnet) and then change the default confirmations to 1.3. DevX Improvement: . README updates and added inline docs to the function so that it shows on however in the IDE
However: