Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable timing out requests on Coordinator v1.3.1 #66

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Enable timing out requests on Coordinator v1.3.1 #66

merged 1 commit into from
Aug 6, 2024

Conversation

KuphJr
Copy link
Contributor

@KuphJr KuphJr commented Jul 18, 2024 •
edited
Loading

No description provided.

@KuphJr KuphJr requested a review from zeuslawyer as a code owner July 18, 2024 19:09
@KuphJr KuphJr requested a review from justinkaseman July 18, 2024 19:09
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@KuphJr
Copy link
Contributor Author

KuphJr commented Jul 18, 2024

We can either set the adminFee to zero in the timeoutRequests method or in the fetchRequestCommitment method. @justinkaseman any thought on what is best here?
You can see an example of how these 2 methods are meant to be used here: https://github.com/smartcontractkit/functions-hardhat-starter-kit/blob/main/tasks/Functions-billing/timeoutRequests.js#L30-L50

@KuphJr KuphJr merged commit 32378e6 into main Aug 6, 2024
5 of 6 checks passed
@KuphJr KuphJr deleted the coordinator-v1.3-timeout-update branch August 6, 2024 14:21
@app-token-issuer-functions app-token-issuer-functions bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agparadiso agparadiso agparadiso approved these changes

@zeuslawyer zeuslawyer Awaiting requested review from zeuslawyer zeuslawyer is a code owner

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuphJr @agparadiso