Trigger infra deployment job update#4727
Trigger infra deployment job update#4727denis-chernov-smartcontract wants to merge 5 commits intomainfrom
Conversation
|
denis-chernov-smartcontract
requested review from
dskloetc,
mmcallister-cll and
mxiao-cll
| - build-publish | ||
| if: needs.calculate-changes.outputs.adapter-list != '{"adapter":[]}' | ||
| - build-publish-streams | ||
| if: > |
There was a problem hiding this comment.
Can you add a comment here explaining exactly why we need always()? Which job might be skipped and why do we still want to run this if it was skipped?
There was a problem hiding this comment.
Added
| --json number \ | ||
| --jq '.[0].number // empty') | ||
| --json number,title \ | ||
| --jq ".[] | select(.title == \"Release $BUMPED_VERSION\") | .number") |
There was a problem hiding this comment.
What does this change do and why is it needed?
There was a problem hiding this comment.
In my initial implementation, I was utilizing the gh pr list --search command, which uses GitHub's search API, which has eventual consistency — there's a delay between when a PR is created and when it becomes searchable.
New code uses the REST API (not the search API) and is immediately consistent.
There was a problem hiding this comment.
Can you add a comment explaining this so someone doesn't accidentally change it back to use the search API in the future?
There was a problem hiding this comment.
Done
There was a problem hiding this comment.
Can you add to the PR description what problem we have today that this PR is trying to solve? Is something not working? Did something go wrong? Do we anticipate something might not work under which conditions?
There was a problem hiding this comment.
Added an image to illustrate the change.
There was a problem hiding this comment.
I'm specifically asking about the "why" rather than the "what". That's why I asked these question:
What problem do we have today that this PR is trying to solve? Is something not working? Did something go wrong? Do we anticipate something might not work under which conditions?
2 participants
Description
Updated deploy so infra dispatch waits on streams build when needed, without blocking when streams is off.
What changed in deploy.yml