feat: move transfer ownership solana to cld-changesets#59
Closed
ajaskolski wants to merge 1 commit into
Closed
Conversation
ajaskolski
force-pushed
the
hore-move-transfer-ownership-solana-from-core
branch
from
1f15936 to
e548d17
Compare
ajaskolski
force-pushed
the
hore-move-transfer-ownership-solana-from-core
branch
from
e548d17 to
626e10f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the Solana “transfer ownership to timelock” workflow into the legacy/mcms/changesets area, including an integration-style test that deploys MCMS+Timelock and validates ownership transfer via a proposal execution.
Changes:
- Added a Solana ownership transfer changeset that submits on-chain transfer instructions and builds an MCMS timelock proposal for accept-ownership.
- Added a test that deploys MCMS+Timelock in a Solana test environment, executes the transfer changeset, and asserts the new owner is the timelock signer PDA.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| legacy/mcms/changesets/transfer_ownership_solana.go | Adds Solana ownership transfer changeset + helper instruction builders for seeded/seedless programs. |
| legacy/mcms/changesets/transfer_ownership_solana_test.go | Adds runtime-based Solana test verifying transfer + accept ownership end-to-end. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+313
to
+322
| timelocks := map[uint64]string{} | ||
| proposers := map[uint64]string{} | ||
| inspectors := map[uint64]mcmssdk.Inspector{} | ||
| instructions := make([]solana.Instruction, 0, 1) | ||
| chainSelector := solChain.ChainSelector() | ||
|
|
||
| timelocks[chainSelector] = solanaAddress(chainState.TimelockProgram, mcmssolanasdk.PDASeed(chainState.TimelockSeed)) | ||
| proposers[chainSelector] = solanaAddress(chainState.McmProgram, mcmssolanasdk.PDASeed(chainState.ProposerMcmSeed)) | ||
| inspectors[chainSelector] = mcmssolanasdk.NewInspector(solChain.Client) | ||
|
|
ajaskolski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports transfer ownership solana.
https://smartcontract-it.atlassian.net/browse/CLD-1925