-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CTF v2 approach to run the anvil chains #15751
Open
b-gopalswami
wants to merge
11
commits into
develop
Choose a base branch
from
ccip-4455
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+560
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
b-gopalswami
requested review from
chudilka1,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
skudasov
December 18, 2024 22:54
I see you updated files related to
|
b-gopalswami
force-pushed
the
ccip-4455
branch
from
December 19, 2024 14:38
cdc3291
to
d092f2e
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial attempt to implement CTF v2 features. Have tested
TestTransferToken
primarily and it runs fine with this implementation. Haven't run all other test and there might be some missing pieces as well. Making this work across all the test has to be separate work.At this point, the speed comparison looks better in terms of network and required contract deployment setup however the CCIP transaction is bit slower and the overall execution time slightly more than docker.
Setup time is less by ~40-50 seconds. Overall time is increased by ~30s.
Needs further investigation to understand why it takes more time in finding the commit report event and execution status changed event.
The key features from CTF v2 to note:
To run the test with this approach, set these env variables.
CCIP_V16_TEST_ENV=anvil-docker; CTF_CONFIGS=../../testconfig/ccip/ccip-default-ctfv2.toml
To spin up local observability,
Run
ctf obs u
for grafana;Run
ctf bs u
for blockscout