Check sourceChainSelectors len in GetOffRampSourceChainConfigs #571
+137
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the GetOffRampSourceChainConfigs function where the wrong variable was being checked to determine if all chain configs should be returned.
Changes:
- Corrected the condition check from
len(sourceChainConfigs)tolen(sourceChainSelectors)to properly detect when no specific selectors are requested.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
huangzhen1997
previously approved these changes
Feb 2, 2026
krebernisak
previously approved these changes
Feb 3, 2026
…mpSourceChainConfigs-check-sourceChainSelectors
ogtownsend
force-pushed
the
ogt/accessor-GetOffRampSourceChainConfigs-check-sourceChainSelectors
branch
from
73745f0 to
68c6d1f
Compare
…mpSourceChainConfigs-check-sourceChainSelectors
auto-merge was automatically disabled
February 4, 2026 00:09
Pull request was converted to draft
…mpSourceChainConfigs-check-sourceChainSelectors
ogtownsend
dismissed stale reviews from krebernisak and huangzhen1997
via
ed77eb3
ogtownsend
force-pushed
the
ogt/accessor-GetOffRampSourceChainConfigs-check-sourceChainSelectors
branch
from
f5f3cf8 to
ed77eb3
Compare
ogtownsend
force-pushed
the
ogt/accessor-GetOffRampSourceChainConfigs-check-sourceChainSelectors
branch
from
662497a to
cb23827
Compare
…mpSourceChainConfigs-check-sourceChainSelectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.