commit report codec merkle root validation #569
+46
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces TON blockchain's requirement that commit reports contain exactly one unblessed merkle root, aligning the codec with on-chain contract constraints.
Changes:
- Added validation in the commit codec to enforce exactly one unblessed merkle root per report
- Migrated merkle roots from blessed to unblessed status throughout the codebase
- Updated test cases to validate the new single merkle root requirement
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/ccip/codec/commitcodec.go | Added validation requiring exactly 1 unblessed merkle root; removed blessed merkle root handling |
| pkg/ccip/codec/commitcodec_test.go | Removed second merkle root from test data; added test cases for merkle root count validation |
| pkg/ccip/chainaccessor/ton_accessor.go | Changed merkle roots from blessed to unblessed status |
| integration-tests/smoke/chainaccessor/accessor_test.go | Updated assertions to check unblessed instead of blessed merkle roots |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
huangzhen1997
commented
Feb 2, 2026
| // TON does not support RMN verification, so BlessedMerkleRoots will be ignored. | ||
| // TON on-chain OffRamp requires exactly one merkle root per commit report. | ||
| // See Error.BatchingNotSupported in contracts/contracts/ccip/offramp/contract.tolk | ||
| if len(report.UnblessedMerkleRoots) != 1 { |
Contributor
Author
There was a problem hiding this comment.
@vicentevieytes Does this look right to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.