Support SUI extraArgs in codec #565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Sui blockchain's extra arguments in the CCIP codec, extending the existing framework that handles EVM and SVM extra arguments.
Changes:
- Introduced
SuiExtraArgsV1struct to represent Sui-specific transaction parameters - Refactored
DecodeExtraArgsToMapto use a map-based dispatch mechanism for handling different extra args types - Added comprehensive test coverage for Sui extra args encoding/decoding
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/ccip/bindings/onramp/onramp.go | Added SuiExtraArgsV1 struct definition with gas limit, execution ordering, token receiver, and object IDs |
| pkg/ccip/bindings/onramp/onramp_test.go | Added test case to verify encoding and decoding of SuiExtraArgsV1 |
| pkg/ccip/codec/extradatacodec.go | Refactored decoder to use map-based type lookup and added Sui extra args tag support |
| pkg/ccip/codec/extradatacodec_test.go | Added test case for decoding Sui extra args into a map |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.