Forwarder #1179

augustbleeds · 2025-04-10T18:28:09Z

Description

Design of forwarder based off of #614

EDIT: please see the committed README.md docs for more info

instructions:

initialize: creates a new forwarder state, and precomputes the bump for the forwarder authority pda which signs the CPI to the receiver
transfer/accept_ownership: self-explanatory
init/update/close_oracles_config: oracle configs (which are called oracle sets in EVM) are stored as separate data accounts since a new config version / config_id with the same DON would create a new oracle config so the size is unbounded (as opposed to finding a soft-limit on the new dons that are created)
report: processes the report which is of format data = bump | len_signatures (N) | signatures (N*65) | raw_report (M) | report_context (96). A report will create a new execution_state pda data account if doesn't exist via create_account instruction. It executes a CPI to a receiver program where the forwarder authority pda is the signer.

Requires Dependencies

Resolves Dependencies

dhaidashenko · 2025-04-14T11:49:35Z

contracts/programs/keystone-forwarder/src/lib.rs

+
+    use super::*;
+
+    pub fn initialize(ctx: Context<Initialize>) -> Result<()> {


Curious about what steps we need to perform for deployment. Is it

Deploy the program.

Initialize (can we do it as part of the deployment transaction?)

Init oracles config

Transfer ownership to MCMS

Accept ownership on MCMS

contracts/programs/keystone-forwarder/src/lib.rs

dhaidashenko · 2025-04-14T12:06:11Z

contracts/programs/keystone-forwarder/src/lib.rs

+#[account]
+#[derive(Default)]
+#[derive(InitSpace)]
+pub struct ExecutionState {


I wonder how we can verify if the report was forwarded on the WriteTarget level

can you elaborate on the scenario? we can add an event to the report function which you can listen to or you can query the execution status account associated with the transmission

contracts/programs/keystone-forwarder/src/lib.rs

archseer · 2025-04-15T01:19:26Z

contracts/programs/keystone-forwarder/src/lib.rs

+pub struct OraclesConfig {
+    config_id: u64,
+    f: u8,
+    signer_addresses: Vec<EthAddress>, // maybe think about doing ECDSA over ed25519?


Personally I'd use a constant size array plus a length int and make the type zero_copy

@chray-zhang

archseer · 2025-04-15T04:02:51Z

contracts/programs/keystone-forwarder/src/lib.rs

+    let data = &data[2..];
+    let _signatures = &data[..65*len];
+    let data = &data[65*len..];
+    let _report_context = &data[data.len()-96..];


I think it would make more sense to have the report context before the report

I kept it this way because the existing solana keyring assumes the report context comes after https://github.com/smartcontractkit/chainlink/blob/develop/core/services/keystore/keys/ocr2key/solana_keyring.go#L38 . But open to changing it as well.

We should be using ocr2 signatures, not ocr3 right?

contracts/programs/keystone-forwarder/src/lib.rs

archseer · 2025-04-15T04:06:37Z

contracts/programs/keystone-forwarder/src/lib.rs

+        prev_signer = curr_signer;
+    }
+
+    oracles_config.config_id = ((don_id as u64) << 32) | (config_version as u64);


This should use get_config_id

archseer · 2025-04-15T04:07:13Z

contracts/programs/keystone-forwarder/src/lib.rs

+}
+
+fn get_config_id(don_id: u32, config_version: u32) -> u64 {
+    ((don_id as u64) << 32) | (config_version as u64)


Config id could technically just be a struct with two u32 fields, it would have the same underlying size

* Adding events to forwader contract * README update for nix test * Revision 1 * rust lint * removed unnecc * nits

cl-sonarqube-production · 2025-05-30T20:19:36Z

Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

augustbleeds requested a review from a team as a code owner April 10, 2025 18:28

augustbleeds temporarily deployed to integration April 10, 2025 18:28 — with GitHub Actions Inactive

augustbleeds had a problem deploying to integration April 10, 2025 18:28 — with GitHub Actions Failure

augustbleeds temporarily deployed to integration April 10, 2025 18:28 — with GitHub Actions Inactive

dhaidashenko reviewed Apr 14, 2025

View reviewed changes

archseer reviewed Apr 15, 2025

View reviewed changes

contracts/programs/keystone-forwarder/src/lib.rs Outdated Show resolved Hide resolved

archseer reviewed Apr 15, 2025

View reviewed changes

archseer requested review from toblich, PabloMansanet and agusaldasoro April 15, 2025 04:07

augustbleeds temporarily deployed to integration April 18, 2025 19:31 — with GitHub Actions Inactive

augustbleeds had a problem deploying to integration April 18, 2025 19:31 — with GitHub Actions Failure

augustbleeds temporarily deployed to integration April 18, 2025 19:31 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration April 21, 2025 17:21 — with GitHub Actions Inactive

augustbleeds had a problem deploying to integration April 21, 2025 17:21 — with GitHub Actions Failure

augustbleeds temporarily deployed to integration April 22, 2025 19:46 — with GitHub Actions Inactive

augustbleeds had a problem deploying to integration April 22, 2025 19:46 — with GitHub Actions Failure

augustbleeds temporarily deployed to integration April 22, 2025 19:46 — with GitHub Actions Inactive

augustbleeds had a problem deploying to integration April 22, 2025 19:46 — with GitHub Actions Failure

augustbleeds temporarily deployed to integration April 22, 2025 19:46 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration April 22, 2025 19:54 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 23, 2025 14:43 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 23, 2025 14:48 — with GitHub Actions Inactive

Adding events to forwarder contract (#1251)

520c659

* Adding events to forwader contract * README update for nix test * Revision 1 * rust lint * removed unnecc * nits

chray-zhang dismissed their stale review via 520c659 May 30, 2025 13:54

chray-zhang temporarily deployed to integration May 30, 2025 13:54 — with GitHub Actions Inactive

chray-zhang temporarily deployed to integration May 30, 2025 14:05 — with GitHub Actions Inactive

Merge branch 'develop' into augustus.NONEVM-1516.forwarder

5be4032

augustbleeds temporarily deployed to integration May 30, 2025 14:22 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 30, 2025 14:27 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 30, 2025 14:28 — with GitHub Actions Inactive

Merge branch 'develop' into augustus.NONEVM-1516.forwarder

5d333be

augustbleeds temporarily deployed to integration May 30, 2025 19:58 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 30, 2025 20:03 — with GitHub Actions Inactive

augustbleeds temporarily deployed to integration May 30, 2025 20:04 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forwarder #1179

Forwarder #1179

Uh oh!

augustbleeds commented Apr 10, 2025 •

edited

Loading

Uh oh!

dhaidashenko Apr 14, 2025

Uh oh!

Uh oh!

dhaidashenko Apr 14, 2025

Uh oh!

augustbleeds May 2, 2025

Uh oh!

Uh oh!

archseer Apr 15, 2025

Uh oh!

augustbleeds May 14, 2025

Uh oh!

archseer Apr 15, 2025

Uh oh!

augustbleeds Apr 22, 2025

Uh oh!

Uh oh!

archseer Apr 15, 2025

Uh oh!

aalu1418 May 1, 2025

Uh oh!

archseer Apr 15, 2025

Uh oh!

cl-sonarqube-production bot commented May 30, 2025

Uh oh!

Uh oh!


		use super::*;

		pub fn initialize(ctx: Context<Initialize>) -> Result<()> {

Forwarder #1179

Are you sure you want to change the base?

Forwarder #1179

Uh oh!

Conversation

augustbleeds commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Requires Dependencies

Resolves Dependencies

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cl-sonarqube-production bot commented May 30, 2025

Quality Gate passed

Uh oh!

Uh oh!

augustbleeds commented Apr 10, 2025 •

edited

Loading