feat: node public key retrieval #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 055231b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
ChrisAmora
force-pushed
the
feat/node-public-key
branch
from
545fcc8 to
d1167e1
Compare
ChrisAmora
force-pushed
the
feat/node-public-key
branch
from
d1167e1 to
b65f833
Compare
| @@ -172,6 +173,7 @@ message ListNodesRequest { | |||
| repeated string ids = 1; | |||
| EnableState enabled = 2; | |||
| repeated api.label.Selector selectors = 3; | |||
| repeated string public_keys = 4; | |||
There was a problem hiding this comment.
Update the comment for ListNodesRequest?
job-distributor/v1/node/node.proto
Outdated
| @@ -143,6 +143,7 @@ message RegisterNodeResponse { | |||
| // GetNodeRequest is the request to retrieve a single node by its ID. | |||
There was a problem hiding this comment.
need to update the comment here too
ChrisAmora
force-pushed
the
feat/node-public-key
branch
from
8cf7677 to
c227105
Compare
graham-chainlink
approved these changes
Dec 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add public key to ListNodesRequest Filter and GetNodeRequest