feat: use mcms' chainwrappers instead of custom builders/factories#847
Merged
gustavogama-cll merged 1 commit intomainfrom Mar 12, 2026
Merged
feat: use mcms' chainwrappers instead of custom builders/factories#847gustavogama-cll merged 1 commit intomainfrom
gustavogama-cll merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5bb5251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/chore/use-mcms-chainwrappers
branch
2 times, most recently
from
0a8c26a to
a55bd39
Compare
gustavogama-cll
force-pushed
the
ggama/chore/use-mcms-chainwrappers
branch
from
a55bd39 to
5bb5251
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces locally implemented MCMS inspector/converter/executor builders in the test/runtime and CLI fork-execution paths with the upstream mcms/chainwrappers helpers (OPT-438), simplifying chain-specific wiring.
Changes:
- Switch executor and conversion logic to
chainwrappers.Build*helpers (executors, timelock executors, converters, inspector). - Remove custom per-chain factories/helpers and their associated unit tests.
- Update runtime executor interface + mock to accept variadic execution options (timelock action).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/test/runtime/task_mcms.go | Extends proposalExecutor.ExecuteMCMS to accept variadic execution options. |
| engine/test/runtime/mock_proposal_executor_test.go | Updates generated mock for new ExecuteMCMS signature (variadic opts). |
| engine/test/internal/mcmsutils/executor.go | Uses chainwrappers to build executors/timelock executors; introduces WithTimelockAction option. |
| engine/test/internal/mcmsutils/conversion.go | Uses chainwrappers.BuildConverters instead of custom converter factory selection. |
| engine/test/internal/mcmsutils/conversion_test.go | Updates error expectations to match new chainwrappers error paths/messages. |
| engine/test/internal/mcmsutils/errors.go | Removes now-unused helper constructors; keeps exported sentinel error. |
| engine/test/internal/mcmsutils/stub_test.go | Adjusts EVM stub chain to include a deployer key; removes Solana stub. |
| engine/test/internal/mcmsutils/{aptos,evm,solana}.go | Removes chain-specific factory implementations (now superseded by chainwrappers). |
| engine/test/internal/mcmsutils/{aptos,evm,solana,factory}_test.go | Removes tests that were validating the deleted factory implementations. |
| engine/cld/commands/mcms/chain_helpers.go | Replaces chain-family switch logic with chainwrappers builders for inspector/executor/timelock executor. |
| engine/cld/commands/mcms/chain_helpers_{aptos,sui}.go | Removes now-unused chain-specific helper functions. |
| chain/mcms/adapters/chain_access.go | Adds compile-time assertion that chain.BlockChains satisfies ChainsFetcher. |
| .changeset/smooth-heads-jam.md | Adds changeset entry for the patch release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graham-chainlink
approved these changes
Mar 12, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.86.2 ### Patch Changes - [#851](#851) [`98b91fb`](98b91fb) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix: preserve json number accuracy on marshal and unmarshal - [#847](#847) [`fa1639e`](fa1639e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: use mcms chainwrappers helpers --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom logic to build mcms inspectors/converters/executors with the helpers from the "chainwrappers" package.
OPT-438