Skip to content

Conversation

@graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Jan 30, 2026

Split provider tests into separate jobs to improve CI performance:

  • Aptos, Canton, TON, and TRON providers now run in dedicated jobs as they take longer than 60sec due to docker image container startup time.
  • Remaining fast providers run together with exclusion pattern
Screenshot 2026-01-30 at 9 16 37 pm

Also reduced Canton test validators from 5 to 1 for faster execution.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: d26c572

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink force-pushed the ggoh/reduce-canton-ctf-validators branch from cc509ee to d3b4a13 Compare January 30, 2026 09:56
@graham-chainlink graham-chainlink changed the title Test: reduce canton CTF validator count ci(test): parallelize slow provider tests in CI workflow Jan 30, 2026
giveSelector: chainsel.CANTON_LOCALNET.Selector,
giveConfig: CTFChainProviderConfig{
NumberOfValidators: 5,
NumberOfValidators: 1,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be 1 instead of spinning up 5 validators to save some setup time.

@graham-chainlink graham-chainlink marked this pull request as ready for review January 30, 2026 10:13
@graham-chainlink graham-chainlink requested a review from a team as a code owner January 30, 2026 10:13
Copilot AI review requested due to automatic review settings January 30, 2026 10:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes CI performance by parallelizing slow provider tests that involve Docker container startup overhead.

Changes:

  • Separated Aptos, Canton, TON, and TRON provider tests into dedicated jobs with appropriate timeouts (5-10 minutes)
  • Reduced Canton test configuration from 5 validators to 1 for faster execution
  • Configured remaining fast provider tests to run together with exclusion patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
chain/canton/provider/ctf_provider_test.go Reduced number of validators from 5 to 1 to speed up Canton tests
.github/workflows/pull-request-main.yml Split single provider test job into five parallel jobs with specific timeout configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Split provider tests into separate jobs to improve CI performance:
- Aptos, Canton, TON, and TRON providers now run in dedicated jobs
- Canton gets 10min timeout (takes ~4min), others get 5min
- Remaining fast providers run together with exclusion pattern

Also reduced Canton test validators from 5 to 1 for faster execution.
@graham-chainlink graham-chainlink force-pushed the ggoh/reduce-canton-ctf-validators branch from d3b4a13 to d26c572 Compare January 30, 2026 10:16
@cl-sonarqube-production
Copy link

# disable the checkptr runtime check due a false positive in github.com/xssnick/tonutils-go
# causing tests in ci to fail "fatal error: checkptr: pointer arithmetic result points to invalid allocation"
# https://github.com/xssnick/tonutils-go/issues/310
go-test-cmd: go test -race -gcflags=all=-d=checkptr=0 -coverprofile=coverage.txt ./chain/ton/provider/...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command has extra gcflags was that intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ton needs the extra flag, refer to the comment # disable the checkptr runtime check due a false positive in github.com/xssnick/tonutils-go

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this existed in previous change

Copy link
Contributor

@bytesizedroll bytesizedroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@graham-chainlink graham-chainlink added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 436d759 Feb 2, 2026
20 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/reduce-canton-ctf-validators branch February 2, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants