Do not use go-ethereum for hasher. #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
force-pushed
the
will/no-evm-hasher
branch
2 times, most recently
from
b194d49 to
3e87205
Compare
0xAustinWang
reviewed
Oct 9, 2025
protocol/hashing.go
Outdated
| h.Write(data) //nolint:revive // keccak256 never returns an error | ||
| var out [32]byte | ||
| copy(out[:], h.Sum(nil)) | ||
| h.Reset() |
There was a problem hiding this comment.
is this h.reset necessary? We already reset right before usage on line 24
There was a problem hiding this comment.
Good point. The pool is private, so there's no benefit to the extra caution.
|
|
CI failing, but will approve after |
makramkd
reviewed
Oct 17, 2025
Comment on lines
+10
to
+14
| var hasherPool = sync.Pool{ | ||
| New: func() any { | ||
| return sha3.NewLegacyKeccak256() | ||
| }, | ||
| } |
There was a problem hiding this comment.
It lets you reuse the keccak objects instead of reallocating them every time. I'll add a benchmark, now I'm curious how impactful it is.
There was a problem hiding this comment.
Looks like object pooling improves things from 378ns -> 251.2ns. I tested with different inputs, and it seems to be a fixed ~100ns overhead for object allocation with the total duration going up based on the input data size.
goos: linux
goarch: amd64
pkg: github.com/smartcontractkit/chainlink-ccv/protocol
cpu: 13th Gen Intel(R) Core(TM) i9-13900HX
BenchmarkHashing
BenchmarkHashing-32 4575128 251.2 ns/op
BenchmarkHashinbBaseline
BenchmarkHashinbBaseline-32 2765898 378.0 ns/op
PASS
fdffd2c to
085ba4d
Compare
E2E Smoke Test Results
Full logs are available in the workflow artifacts. |
|
Code coverage report:
|
makramkd
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-ethereum hash function we need is a trivial wrapper around standard go libraries. Use them directly rather than calling into go-ethereum.