fix: manualExec --estimate-gas-limit
smaller than original
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to estimate-gas-limit and get a limit smaller than request's gasLimit, you get a thrown estimation error due to trying to manually execute with a smaller gasLimitOverride.
This adds a check, with a logged
warn
in that case, and keeps the original (=0
) gas limit, which will succeed anyway (in case you could estimate)