Skip to content

Render custom skin boxes on viewmodel#1415

Merged
sylvessa merged 3 commits intosmartcmd:mainfrom
BotchGit:BotchGit-PR-Viewmodel-Boxes
Mar 28, 2026
Merged

Render custom skin boxes on viewmodel#1415
sylvessa merged 3 commits intosmartcmd:mainfrom
BotchGit:BotchGit-PR-Viewmodel-Boxes

Conversation

@BotchGit
Copy link
Copy Markdown
Contributor

Description

This PR fixes the custom skin boxes not being rendered on the viewmodel.

Changes

The custom skin boxes now correctly render with the viewmodel.

Previous Behavior

Previously the custom skin boxes did not render, which wasn't a huge issue unless you were using a model that replaces the default arm with a custom box while hiding the original arm with an anim bitmask. In this screenshot you can see what the sackboy skin looks like in first person mode right now.
old Minecraft Client_yNJ4d5oGuc

Root Cause

Game just wasn't rendering the boxes with the viewmodel as it should and does in official console versions of the game.

New Behavior

Here, you can see that the game now properly renders the custom skin boxes with the viewmodel.
Minecraft Client_vgp6HLgf4S
Minecraft Client_PQfYSyQrQ1

Fix Implementation

Loop through children of arm0 and see if they match the ModelParts that are for the current skin, if they do render them with the viewmodel.

AI Use Disclosure

None

Related Issues

@BotchGit
Copy link
Copy Markdown
Contributor Author

DO NOT MERGE YET!!!

somehow missed a bug last night where selecting a skin with no boxes at all will crash the game.
fixing asap

@BotchGit
Copy link
Copy Markdown
Contributor Author

Ok newest commit should fix 👍

@sylvessa
Copy link
Copy Markdown
Collaborator

will merge when workflow succeeds

@sylvessa sylvessa merged commit 277d747 into smartcmd:main Mar 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants