add support for linux clang cross compiles#1403
Open
ryleu wants to merge 1 commit intosmartcmd:mainfrom
Open
Conversation
Author
|
sorry for the giant diff, but it had to be done at some point |
|
Doesn't #465 do the same thing as this PR? |
|
Could you modify COMPILE.md to add some instructions on how to compile it with clang? |
Contributor
|
@StevenSYS yes but it's really old. |
Author
yeah i can this weekend. all the steps are in flake.nix if you wanna test it right now tho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add support for compiling the exe from linux using clang
Changes
Previous Behavior
builds on linux with clang would fail in a number of ways
Root Cause
mostly due to weird capitalization issues and the use of backslashes in file paths
New Behavior
file paths now use forward slashes and proper capitalization, which shouldn't affect how it builds with msvc
Fix Implementation
i used a lot of sed find and replace. i also added a nix flake for building on nixos, which can serve as a sort of build instructions for people on linux too.
AI Use Disclosure
just for debugging help, not for any actual code writing. i never copy-pasted any ai code into my editor
Related Issues