Parity: Climbable trapdoors if connected to a ladder.#1329
Closed
hexagonny31 wants to merge 10 commits intosmartcmd:mainfrom
Closed
Parity: Climbable trapdoors if connected to a ladder.#1329hexagonny31 wants to merge 10 commits intosmartcmd:mainfrom
hexagonny31 wants to merge 10 commits intosmartcmd:mainfrom
Conversation
### Previous Behavior Trapdoors still has collision even if opened, making it difficult to climb with. ### New Behavior - Added a new condition in `LivingEntity::onLadder()` in case it's a trapdoor, then return as true (as if its a ladder). - If there's a ladder under the (opened) trapdoor, then its collision box returns as a nullptr. **Files:** - `LivingEntity.cpp` - `TrapDoorTile.cpp` **Methods:** - `LivingEntity::onLadder()` - `TrapDoorTile::getAABB(Level *level, int x, int y, int z)`
Made so that it avoids alternating use of ladders (or vines) and trapdoors.
Just incase if neighborChanged is modified.
The same result but neglecting the update tick could make weird effects.
Going full Java parity. Ngl, having a different collision box was a cool idea but probably best for implementing new tiles.
hexagonny31
changed the title
Commented attachedTo checks, made so mayPlace always return true, and implemented setPlacedBy for directional placing when the player placed the trapdoor on the floor or ceiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A feature parity, when open trapdoors act as climbable ladders if they are placed directly above a ladder and against the wall.
Changes
Previous Behavior
Trapdoors has a thickness of 3 pixels while ladders have only 2. I hate this so much and in dire need to make my attic trapdoor to seamlessly be climbable.
2026-03-18.09-49-37.mp4
New Behavior
LivingEntity::onLadder()in case it's a trapdoor, then return as true (as if its a ladder).2026-03-23.15-23-03.mp4
Files:
LivingEntity.cppLadderTile.cppMethods:
LivingEntity::onLadder()LadderTile::setShape(int data)AI Use Disclosure
No AI