-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add core__diagnosticreport table #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
mikix
force-pushed
the
mikix/diagnostics
branch
2 times, most recently
from
December 3, 2024 21:38
4252a56
to
45c899a
Compare
mikix
commented
Dec 3, 2024
mikix
force-pushed
the
mikix/diagnostics
branch
from
December 3, 2024 21:40
45c899a
to
1fb444c
Compare
mikix
changed the title
WIP: core: add core__diagnosticreport table
core: add core__diagnosticreport table
Dec 3, 2024
dogversioning
approved these changes
Dec 4, 2024
Comment on lines
4
to
15
-- This table includes all fields of interest to the US Core DiagnosticReport profiles. | ||
-- EXCEPT FOR: | ||
-- * the 'presentedForm' field, which is an attachment array that is stripped out by the ETL. | ||
-- * the `reporter` field, simply due to it not likely being interesting to consumers | ||
-- and being an array field, which would require a lot of row duplication. | ||
-- | ||
-- US Core profiles for reference: | ||
-- * https://hl7.org/fhir/us/core/STU4/StructureDefinition-us-core-diagnosticreport-lab.html | ||
-- * https://hl7.org/fhir/us/core/STU4/StructureDefinition-us-core-diagnosticreport-note.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh what a nice piece of documentation that we should replicate across all the main core templates
mikix
force-pushed
the
mikix/diagnostics
branch
from
December 4, 2024 16:05
1fb444c
to
0c01575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
docs/
needs to be updatedgenerate-md
core
study fields that not in US Core, update our list of those incore-study-details.md
manifest.toml