Move MedReq and Allergy references to end of table #295
Conversation
mikix
changed the title
| mr.authoredOn, | ||
| mr.authoredOn_month, | ||
|
|
||
| concat('MedicationRequest/', mr.id) AS medicationrequest_ref, |
There was a problem hiding this comment.
It's a little hard to see because I rearranged how this table gets generated (to more easily inject the code triplet in the middle of the list). But this line here is new - I added it because it seems standard for core tables to have this kind of field (and it makes sense).
mikix
force-pushed
the
mikix/table-order
branch
from
9fff4c6 to
1bf4f27
Compare
| BOOL_OR(ec.table_name = 'condition') | ||
| BOOL_OR(ec.table_name = 'allergyintolerance') | ||
| AND BOOL_OR(ec.table_name = 'condition') |
There was a problem hiding this comment.
This is from a previous PR where I forgot to regenerate SQL after making a change.
Since the current flow is to generate SQL from test data, we could add a check in the CI to regenerate SQL and see if there are any changes - failing the PR if so... Just a thought for later
There was a problem hiding this comment.
#182 - it's been hanging around for a bit, but it remains a good idea.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Checklist
docs/needs to be updatedgenerate-mdcorestudy fields that not in US Core, update our list of those incore-study-details.mdmanifest.toml