Better discovery of manifest location #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
approved these changes
Sep 12, 2023
| return manifest_studies | ||
|
|
||
|
|
||
| def get_studies_by_manifest_path(path: PosixPath) -> dict: |
There was a problem hiding this comment.
This seems like something I would go to os.walk for, but PosixPath is doing a lot of the work for you too. 👍
There was a problem hiding this comment.
There's def more than one way to do this - I'm making a conscious decision over in this to use pathlib.PosixPath when there's rough equivalence just so there's one pattern for someone to pick up.
This was referenced Sep 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #108 by recursively searching for manifest files, rather than assuming the user is running this search in a specific place.
Checklist
docs/) needs to be updated