Upadted dict handling for metadata #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
commented
Feb 7, 2025
src/shared/functions.py
Outdated
Comment on lines
115
to
118
| logger.info(f"### Updating metadata {meta_type}") | ||
| logger.info(f"{study} {data_package} {version}") | ||
| logger.info(f"Key: {target} Value: {value}") | ||
| logger.info(f"Pre-update size: {len(metadata.keys)}") |
There was a problem hiding this comment.
Did I actually catch this? well, we'll see. This logging is in here to hopefully create some breadcrumbs. Should be temporary.
mikix
approved these changes
Feb 7, 2025
src/shared/functions.py
Outdated
Comment on lines
117
to
126
| version, TRANSACTION_METADATA_TEMPLATE | ||
| version, copy.deepcopy(TRANSACTION_METADATA_TEMPLATE) |
There was a problem hiding this comment.
nit: this kind of tricky nuance repeated multiple times gives me pause - maybe make a utility function like _update_metadata that takes some args, I dunno. Or just leave it as is.
There was a problem hiding this comment.
all three stages do something :slightly: different, but i could try to bundle this up a bit better/make it more readable
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates metadata writing to make explicit copies of templates.
In cases where the session is not fully terminated, this resulted in some by ref passing behavior, where the templates would be modified in place and then persist data into the next update operation. This affected unit tests, and :might: have affected lambda behavior as well.
Also made tests of the write process coming in from the S3 manager class much more robust.