Use relative paths for access to modules (avoid sys.path fiddling) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SmartHealthIT capabilities schema issues.
|
Python 2 is finally dead, seems to me all workarounds to support it should be gone! |
|
I'm going to close this in favor of #151 which is a more targeted "just fix python2-isms like importing" - I cherry-picked your original commit here for proper credit. But this PR bundles some fixes together that might be better as separate PRs. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code that fiddles with sys.path. This has resulted in multiple loads of the same module.
This is a minimal change; I did not get rid of all the other tests for python 2.
Tested with python 3.10. Rumor has it it will break on python 2, but do we care?
@ducu review?