Update PDFObject.php #766
Closed
Update PDFObject.php #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small number of abnormal PDFs return an empty result when calling the getDefaultFont() method. Therefore, either modify the getDefaultFont() method or check the input before entering the getTJUsingFontFallback() method to prevent the program from crashing due to errors when reaching the $font->decodeText() line. 小部分异常PDF，调用getDefaultFont()方法返回为空，所以要么去修改getDefaultFont()，要么在进入getTJUsingFontFallback()方法先判错，防止运行到$font->decodeText()报错卡死。
|
Thanks for the PR. Could you provide a test which demonstrates that this fix does what you describe? Either use a real "abnormal" PDF or construct an artificial case. |
|
Please respond or this PR will be closed without further notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request
[ * ] Bug fix (involves code and configuration changes)
About
A small number of abnormal PDFs return an empty result when calling the getDefaultFont() method. Therefore, either modify the getDefaultFont() method or check the input before entering the getTJUsingFontFallback() method to prevent the program from crashing due to errors when reaching the $font->decodeText() line.
小部分异常PDF，调用getDefaultFont()方法返回为空，所以要么去修改getDefaultFont()，要么在进入getTJUsingFontFallback()方法先判错，防止运行到$font->decodeText()报错卡死。