Skip to content

Add PostCommit hooks to Tx #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
areed merged 2 commits into from
Jan 8, 2026
Merged

Add PostCommit hooks to Tx #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8b2c3
Add PostCommit hooks to Tx
areed Jan 6, 2026
1b4461f
Run commit hooks asynchronously
areed Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion sequel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ type Tx struct {
tx *sqlx.Tx
clock clock.Clock
doRebindModel bool
oncommit []func()
}

// Begin begins a transaction and returns a new Tx.
Expand Down Expand Up @@ -441,7 +442,19 @@ func (t *Tx) rebindModel(query string) string {

// Commit commits the transaction.
func (t *Tx) Commit() error {
return t.tx.Commit()
err := t.tx.Commit()
if err != nil {
return err
}
for _, fn := range t.oncommit {
go fn()
}
return nil
}

// PostCommit registers a function to be called asynchronously after a successful commit.
func (t *Tx) PostCommit(fn func()) {
t.oncommit = append(t.oncommit, fn)
}

// Rollback aborts the transaction.
Expand Down