Merge pull request #873 from dickens7/feat-wrie-errormessage

feat: write an error message after you recover
smallnest · Aug 22, 2024 · 0679c4a · 0679c4a
2 parents ee007d3 + 1d758f1
commit 0679c4a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/server/server.go b/server/server.go
@@ -533,8 +533,13 @@ func (s *Server) processOneRequest(ctx *share.Context, req *protocol.Message, co
 		if r := recover(); r != nil {
 			buf := make([]byte, 1024)
 			buf = buf[:runtime.Stack(buf, true)]
-
-			log.Errorf("failed to handle the request: %v， stacks: %s", r, buf)
+			if s.HandleServiceError != nil {
+				s.HandleServiceError(fmt.Errorf("%v", r))
+			} else {
+				log.Errorf("[handler internal error]: servicepath: %s, servicemethod, err: %v，stacks: %s", req.ServicePath, req.ServiceMethod, r, buf)
+			}
+			sctx := NewContext(ctx, conn, req, s.AsyncWrite)
+			sctx.WriteError(fmt.Errorf("%v", r))
 		}
 	}()