Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
Added files: - resources file - MATLABAssignment.prj - names.m Tried to share the code using built-in share function, but turns out that would make a completely new repo! Hopefully I copy-pasted the right stuffs
We're going to be making our own README. I will write down the layout of the README, but we don't necessarily have to conform to it
Added files: - rescale.m -- This is to rescale letters to any size we want, and may be handy when trying to create uppercase versions of some letters since they can be pretty similar - database -- this is for storing letter coordinates, but it may be replaced with something better in the future because I can see that it will be a huge mess later on
Made it so that the coordinates of x and y are together to make it easier to check the coordinates of each letters instead of having to scroll back and forth Files renamed: - database.m -- letters_database.m
These steps are just a draft, not too sure if we're actually going to go do all these, and if in order too
-remove % on the letter_list part
-update on the list of x_coords with lowercase and uppercase letters
-update on the list of y_coords with lowercase and uppercase letters
*Tried to run it but error on letters_dict = dictionary(letters_list, coords) and if ~isKey(letters_dict, {letter})
Just added % to each letter only and have not yet changed the coordinates yet Removed the x_coord & y_coord lists to make it as a combined coords list for both x and y
Changed the following:
- changed [] to {}
- added commas for each letters
- transposed the coords matrix
Added file(s): - translator.m -- to translate the coordinates of the letters to the top and right - splitter.m -- to split strings into chunks depending on delimiter More might come soon
- added x and y coordinates -- for W, A, N, B (uppercase letters)
Added: - endpoint.m -- To determine the final x_coord point of a letter for shifting letters to the right Updates: - names.m -- added clf - translator.m -- Update to instruction which mentions using endpoint.m for shifting letter to the right
I have no idea what these .asv files are and I probably should let them be ignored during commits in case of wanting to check on local last saved?
Added plot coords for c,f,h,i,j,l,o,v,y,z uppercase and lowercase, and T
Customize picture for the banner of the repo to make repo look more pretty-er(?)
Added banner for repo
Renamed file - names.m - plotWord.m
Added plot coords for - t lowercase - g,k,p,q lowercase+uppercase g&p used uppercase waqi sister's guideline so only need 2x rescale - not sure if this is in function yet(?)
changes x y coordinates for; - uppercase X W A N B D * changing from 2by2 to 4by4 grid - lowercase w n b * changing from 1by1 to 2by2 grid
forgot to add x y coordinates for lowercase x - from 1by1 to 2by2
Changing plots for small m
Changing plots for small r
Changing plots for small u
Changing plots for uppercase m
fix on plotword link and sentence to match like letter_database
Rescaled lowercase c,f,g,i,j,k,l,p,t,y
Minor changes
Rescaling some uppercase letters
For bonus task; - Adding colour on each letters (separately) - Can also adjusted the line width of each letter line
Removed files (integrated into plotWord.m: - endpoint.m - splitter.m - translator.m Updated files: - plotWord.m (now a real function)" Added files: - names.m
Updated files: - plotWord.m - letter_database.m
removing this, added the rename file
removing this, added a rename file
Rescaling capital letters starting O to 4x4 size
Updated so the axes will adjust according to length and height of string in plot
Some of the letter plots referred to Pacifico Fonts
Added some photo of font and fix a bit of sentences
Rescaling i and j by 2x2 added dots on small i and j
Updated Task 2 a bit
Updated README some more: - Removed Bonus Tasks - Task 3 <-> Task 4
Fixed i and j
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @NurulShafwana @Ros-2646 @WaqiMTC @fizahjamal