Allow conversion without image

[joewiz]

As proposed in #25, this PR adds a convert_file_without_image function, which can convert AWS-Textract-JSON to PAGE-XML without needing to read the original input image. This function takes the image’s dimensions as inputs, instead of reading these from the image.

The PR also adds “image-width” and “image-height” options to the CLI command, which triggers the use of the new function if they are supplied.

I lack python skills and cobbled this together, so pardon the lack of tests covering the new functionality.

I did run make test-api, which passed. (But make test-cli failed with the same error as before my changes ("No rule to make target OUT, needed by test-cli. Stop.")

I performed the following tests manually, confirming that the results were as expected:

Test 1: Using original features

The following command uses the original features of the utility:

textract2page --output-file page.xml tesseract.json source.jpg

... returned a 66k PAGE-XML file, with the following excerpt on line 8 referencing the input image file:

<pc:Page imageFilename="source.jpg" imageWidth="4593" imageHeight="7163">

Test 2: Using the new features via CLI

The following command uses the new features added in this PR:

textract2page --output-file page2.xml tesseract.json foo.bar --image-width 4593 --image-height 7163

... returned an identical file, except for the following excerpt on line 8, corresponding to the one above:

<pc:Page imageFilename="foo.bar" imageWidth="4593" imageHeight="7163">

I'd greatly appreciate any feedback!

[bertsky]

Many thanks @joewiz, much appreciated!

Your implementation is already near perfect IMO – see below for some cosmetic requests. (If you don't want to work them in, let me know and I'll do it myself.)

[bertsky]

(But make test-cli failed with the same error as before my changes ("No rule to make target OUT, needed by test-cli. Stop.")

Strange! Sounds like your make does not know about target-specific variables, yet. Which version are you using?

[joewiz]

@bertsky Thank you for the review and suggestions! I've incorporated all of them. I would be happy to clean up the PR with a rebase, or the PR could be squashed - either way works for me.

[bertsky]

Excellent, many thanks! I have pushed some fixups and extended the tests. Will merge as soon as CI is happy.