Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix vuln: override autolinker ^4.0.0 #785

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Jun 28, 2024

fixes https://github.com/slsa-framework/slsa-verifier/security/code-scanning/11

markdown-toc's latest v1.2.0 is still vulnerable via a transitive dependency, but hasn't received updates in a long time.

This PR overrides one of the other transitive dependencies to a non-vulnerable version.

more info here jonschlinkert/markdown-toc#156 (comment)

Testing process

  • Manually invoked make markdown-toc and it did succeed, while also adding a missing header in the README.
  • Made a few typos in the headers and markdown-toc did fix them.
  • Cloned markdown-toc, added the override, and its unit tests passed

@ramonpetgrave64 ramonpetgrave64 changed the title deps: fix vuln: override autolinker >= 4.0.0 ^4.0.0 chore: fix vuln: override autolinker >= 4.0.0 ^4.0.0 Jun 28, 2024
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review June 28, 2024 21:13
@ramonpetgrave64
Copy link
Contributor Author

package.json Outdated Show resolved Hide resolved
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 changed the title chore: fix vuln: override autolinker >= 4.0.0 ^4.0.0 chore: fix vuln: override autolinker ^4.0.0 Jul 26, 2024
@loosebazooka
Copy link

loosebazooka commented Aug 13, 2024

sorry I was logged in as distroless-bot

@ramonpetgrave64 ramonpetgrave64 requested a review from a team as a code owner August 13, 2024 18:53
@ramonpetgrave64 ramonpetgrave64 enabled auto-merge (squash) August 13, 2024 18:54
@ramonpetgrave64 ramonpetgrave64 merged commit 3f37511 into slsa-framework:main Aug 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants