Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-preview: Sort selection popup by area of elements #7052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions REUSE.toml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ path = [
"tools/lsp/ui/assets/chevron-down.svg",
"tools/lsp/ui/assets/filter.svg",
"tools/lsp/ui/assets/inspect.svg",
"tools/lsp/ui/assets/list-filter.svg",
"tools/lsp/ui/assets/layout-sidebar**.svg",
"tools/lsp/ui/assets/search.svg",
"tools/lsp/ui/assets/sync.svg",
Expand Down
13 changes: 13 additions & 0 deletions tools/lsp/preview/element_selection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ pub fn filter_sort_selection_stack(
model: slint::ModelRc<crate::preview::ui::SelectionStackFrame>,
filter_text: slint::SharedString,
filter: crate::preview::ui::SelectionStackFilter,
sort_by_area: bool,
) -> slint::ModelRc<crate::preview::ui::SelectionStackFrame> {
use crate::preview::ui::{SelectionStackFilter, SelectionStackFrame};
use slint::ModelExt;
Expand All @@ -469,6 +470,18 @@ pub fn filter_sort_selection_stack(
}
}

let model = if sort_by_area {
Rc::new(model.sort_by(|a, b| {
let a_area = a.width * a.height;
let b_area = b.width * b.height;

a_area.partial_cmp(&b_area).unwrap_or(std::cmp::Ordering::Equal)
}))
.into()
} else {
model
};

let filter_text = filter_text.to_string();

if filter_text.is_empty() && filter == SelectionStackFilter::Everything {
Expand Down
2 changes: 1 addition & 1 deletion tools/lsp/ui/api.slint
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ export global Api {

// ## Element selection:
callback selection-stack-at(x: length, y: length) -> [SelectionStackFrame];
pure callback filter-sort-selection-stack(model: [SelectionStackFrame], filter_text: string, filter: SelectionStackFilter) -> [SelectionStackFrame];
pure callback filter-sort-selection-stack(model: [SelectionStackFrame], filter_text: string, filter: SelectionStackFilter, sort-by-area: bool) -> [SelectionStackFrame];
pure callback find-selected-selection-stack-frame([SelectionStackFrame]) -> SelectionStackFrame;
callback select-element(file: string, offset: int, x: length, y: length);

Expand Down
1 change: 1 addition & 0 deletions tools/lsp/ui/assets/list-filter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 7 additions & 1 deletion tools/lsp/ui/components/selection-popup.slint
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ component PopupInner inherits Rectangle {
}
}

private property <[SelectionStackFrame]> filtered-model: Api.filter-sort-selection-stack(root.selection-stack, filter-edit.text, filter-list.filter);
private property <[SelectionStackFrame]> filtered-model: Api.filter-sort-selection-stack(root.selection-stack, filter-edit.text, filter-list.filter, sort-by-area-button.checked);
border-radius: EditorSizeSettings.radius;

border-width: 0.5px;
Expand Down Expand Up @@ -249,6 +249,12 @@ component PopupInner inherits Rectangle {
}
}
}

sort-by-area-button := Button {
checkable: true;
icon: Icons.list-filter;
colorize-icon: true;
}
}

Rectangle {
Expand Down
1 change: 1 addition & 0 deletions tools/lsp/ui/components/styling.slint
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Palette } from "std-widgets.slint";
export global Icons {
out property <image> add: @image-url("../assets/add.svg");
out property <image> chevron-down: @image-url("../assets/chevron-down.svg");
out property <image> list-filter: @image-url("../assets/list-filter.svg");
out property <image> inspect: @image-url("../assets/inspect.svg");
out property <image> search: @image-url("../assets/search.svg");
out property <image> filter: @image-url("../assets/filter.svg");
Expand Down
Loading