Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict speed setting to fixed-point output with 3 decimal places. #4770

Closed
wants to merge 3 commits into from
Closed

Restrict speed setting to fixed-point output with 3 decimal places. #4770

wants to merge 3 commits into from

Conversation

lordofhyphens
Copy link
Member

@lordofhyphens lordofhyphens commented Mar 30, 2019 •
edited
Loading

Includes test.

Fixes #4769

@lordofhyphens lordofhyphens self-assigned this Mar 30, 2019
@lordofhyphens lordofhyphens requested a review from VanessaE March 30, 2019 18:05
@lordofhyphens lordofhyphens requested a review from alranel as a code owner March 30, 2019 18:05
@lordofhyphens
Copy link
Member Author

@VanessaE your provided config + a benchy should be sufficient to get the large values you were seeing.

@AppVeyorBot
Copy link

✅ Build Slic3r 1.3.0-master-2293 completed (commit f21b47e5f9 by @lordofhyphens)

@AppVeyorBot
Copy link

✅ Build Slic3r 1.3.0-master-2294 completed (commit f564f8bec3 by @lordofhyphens)

VanessaE
VanessaE approved these changes Mar 30, 2019
View reviewed changes
Copy link
Collaborator

@VanessaE VanessaE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AppVeyorBot
Copy link

✅ Build Slic3r 1.3.0-master-2295 completed (commit 11b0103084 by @lordofhyphens)

@lordofhyphens lordofhyphens mentioned this pull request Mar 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanessaE VanessaE VanessaE approved these changes

@alranel alranel Awaiting requested review from alranel alranel is a code owner

Assignees

@lordofhyphens lordofhyphens

Labels
GCode Export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordofhyphens @AppVeyorBot @VanessaE